From nobody Tue Oct 04 13:59:51 2022 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MhfTl3t0hz4dwHY for ; Tue, 4 Oct 2022 13:59:55 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4MhfTk6YG6z3kXM for ; Tue, 4 Oct 2022 13:59:54 +0000 (UTC) (envelope-from hps@selasky.org) Received: from [10.36.2.155] (unknown [178.232.223.95]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id B8145260410; Tue, 4 Oct 2022 15:59:53 +0200 (CEST) Message-ID: <077ca487-2a5c-fba4-513b-9b34322fe547@selasky.org> Date: Tue, 4 Oct 2022 15:59:51 +0200 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: build world fails on raw_ip.c Content-Language: en-US From: Hans Petter Selasky To: garyj@gmx.de Cc: Johan Hendriks , FreeBSD Current References: <20221004153525.7a31a62d@ernst.home> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4MhfTk6YG6z3kXM X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 2a01:4f8:c17:6c4b::2 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-3.30 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net:c]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_TO(0.00)[gmx.de]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,freebsd.org]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/32, country:DE]; R_DKIM_NA(0.00)[]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TAGGED_RCPT(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; DMARC_NA(0.00)[selasky.org]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N On 10/4/22 15:49, Hans Petter Selasky wrote: > On 10/4/22 15:35, Gary Jennejohn wrote: >> On Tue, 4 Oct 2022 15:20:05 +0200 >> Hans Petter Selasky wrote: >> >>> On 10/4/22 15:14, Johan Hendriks wrote: >>>> I just updated the source today but now i get an error building world. >>>> The old build was from yesterday which was fine! >>>> >>>> Building /usr/obj/usr/src/amd64.amd64/sys/KRNL/raw_ip.o >>>> cc -target x86_64-unknown-freebsd14.0 > >>>> --sysroot=/usr/obj/usr/src/amd64.amd64/tmp > >>>> -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin -c -O2 -pipe > >>>> -fno-strict-aliasing -march=broadwell -g -nostdinc  -I. >>>> -I/usr/src/sys > -I/usr/src/sys/contrib/ck/include >>>> -I/usr/src/sys/contrib/libfdt > -D_KERNEL >>>> -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common > >>>> -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer > >>>> -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include > >>>> -fdebug-prefix-map=./x86=/usr/src/sys/x86/include > >>>> -fdebug-prefix-map=./i386=/usr/src/sys/i386/include -mcmodel=kernel >>>> > -mno-red-zone -mno-mmx -mno-sse -msoft-float > >>>> -fno-asynchronous-unwind-tables -ffreestanding -fwrapv >>>> -fstack-protector > -Wall -Wnested-externs -Wstrict-prototypes >>>> -Wmissing-prototypes > -Wpointer-arith -Wcast-qual -Wundef >>>> -Wno-pointer-sign > -D__printf__=__freebsd_kprintf__ >>>> -Wmissing-include-dirs > -fdiagnostics-show-option >>>> -Wno-unknown-pragmas > -Wno-error=tautological-compare >>>> -Wno-error=empty-body > -Wno-error=parentheses-equality >>>> -Wno-error=unused-function > -Wno-error=pointer-sign >>>> -Wno-error=shift-negative-value > -Wno-address-of-packed-member >>>> -Wno-format-zero-length   -mno-aes > -mno-avx  -std=iso9899:1999 >>>> -Werror /usr/src/sys/netinet/raw_ip.c >>>> /usr/src/sys/netinet/raw_ip.c:811:3: error: too few arguments to > >>>> function call, expected 4, have 2 >>>>                   IPSEC_CTLINPUT(ipv4, icmp); >>>>                   ^~~~~~~~~~~~~~~~~~~~~~~~~~ >>>> /usr/src/sys/netipsec/ipsec_support.h:222:61: note: expanded from >>>> macro > 'IPSEC_CTLINPUT' >>>>       ipsec_kmod_ctlinput(proto ## _ipsec_support, __VA_ARGS__) >>>>       ~~~~~~~~~~~~~~~~~~~                                     ^ >>>> /usr/src/sys/netipsec/ipsec_support.h:196:5: note: >>>> 'ipsec_kmod_ctlinput' > declared here >>>> int ipsec_kmod_ctlinput(struct ipsec_support * const, int, >>>>       ^ >>>> 1 error generated. >>>> *** Error code 1 >>>> >>> >>> I've mailed the responsible committer. >>> >>> Just do: >>> >>> diff --git a/sys/amd64/conf/GENERIC b/sys/amd64/conf/GENERIC >>> index 9178abba36cc..ed8045e48257 100644 >>> --- a/sys/amd64/conf/GENERIC >>> +++ b/sys/amd64/conf/GENERIC >>> @@ -30,7 +30,7 @@ options       PREEMPTION              # Enable >>> kernel thread preemption >>>    options        VIMAGE                  # Subsystem virtualization, >>> e.g. VNET >>>    options        INET                    # InterNETworking >>>    options        INET6                   # IPv6 communications >>> protocols >>> -options        IPSEC_SUPPORT           # Allow kldload of ipsec and >>> tcpmd5 >>> +# options      IPSEC_SUPPORT           # Allow kldload of ipsec and >>> tcpmd5 >>>    options                ROUTE_MPATH             # Multipath routing >>> support >>>    options                FIB_ALGO                # Modular fib lookups >>>    options        TCP_OFFLOAD             # TCP offload >>> >>> >>> >>> For now. >>> >> >> There are the usual other problems, like always assuming the every user >> has INET6 defined in their kernel config file. >> >> Here's an error I just saw: >> >> /usr/src/sys/netinet/tcp_subr.c:136:8: error: unknown type name >> 'ip6proto_ctlinput_t'; did you mean 'ipproto_ctlinput_t'? >> static ip6proto_ctlinput_t tcp6_ctlinput; >>         ^~~~~~~~~~~~~~~~~~~ >>         ipproto_ctlinput_t >> /usr/src/sys/netinet/ip_var.h:242:14: note: 'ipproto_ctlinput_t' >> declared here >> typedef void    ipproto_ctlinput_t(struct icmp *); >>                  ^ >> 1 error generated. >> --- tcp_subr.o --- >> *** [tcp_subr.o] Error code 1 >> >> -- >> Gary Jennejohn >> > > I'll leave fixing the LINT-NOINET6 for Gleb. Seems like it needs a bit > more changes. > > At least LINT and GENERIC is fine. > > --HPS Fixed too: https://cgit.freebsd.org/src/commit/?id=c2a808b977dd61c0d69d878cd1bef6b016114d14 Was trivial. --HPS