From nobody Sun Jun 12 15:18:21 2022 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id ED0938415AB for ; Sun, 12 Jun 2022 15:18:22 +0000 (UTC) (envelope-from matteo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LLdct68jvz3tJ8; Sun, 12 Jun 2022 15:18:22 +0000 (UTC) (envelope-from matteo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1655047102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F/slmwwIoG1KIo+OhJwAm+7CBWZfCGH1rb7GCnVQBPA=; b=tzn6YuWYgY8sby/YdtQ3FECNDyQLQKNe2nfDNkQRW7qlifs6K0+e201qPV2mIy4hpUBCsM DllelB3U7GR7i3vVLI2lXEgwGYezCIIQ/2T1VwLNwc22pbXhuXj5pSh+03Hgdnfwj9g6gq SRDqUnu3V1lpThWshOEm9OME8K5CfMBEaFX4eULQNEJeEaz0tfSYC2sed8rMBRJBM0HINZ yXEGCvaRg4NsX7FW84tPOvLd5k9ZHaVYIJqQjCYv3xilJ+n2ViqBszev37UAWq5sXOzO0f b/pJA+mra+A8APCpGfKZFG2dKGORRLTeoRdORhG7UQMAq0Q4aNVy7bWCTEFccQ== Received: from ubertino.local (unknown [IPv6:2601:19b:4400:1779::1008]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: matteo/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 8AF5AF4F9; Sun, 12 Jun 2022 15:18:22 +0000 (UTC) (envelope-from matteo@freebsd.org) Date: Sun, 12 Jun 2022 11:18:21 -0400 From: Matteo Riondato To: Warner Losh Cc: FreeBSD Current Subject: Re: nvme INVALID_FIELD in dmesg.boot Message-ID: <20220612151821.3a2fkfsqlr7ro7gf@ubertino.local> X-PGP-Key: http://rionda.to/files/matteogpg.asc References: <20220525122529.t2kwfg2q65dfiyyt@host-ubertino-mac-88e9fe7361f5.eduroam.ssid.10net.amherst.edu> <20220526001715.4ffee96a@ws1.wobblyboot.net> <20220525153920.sxzi7fhsfzv6yidv@ubertino.local> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="n3rvye4kcg25rgka" Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1655047102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F/slmwwIoG1KIo+OhJwAm+7CBWZfCGH1rb7GCnVQBPA=; b=LuAGVAt5AOrB7Ah9FjWoiK0RqtEwtpK6jvi85DrWHzvl7bPINhBn0PYzEorydpnO625bCi 6OZwVCSomolHeQx2rnomVuWFD+8zuEYJEMaW6YFwOECNoXK+sU51X3PRvd1qHWXZ8qDkUY UZ/ME4VJUzfqeta7eCqYJ7g7wRUfRfdFkO3OrE8uz9uY1tWkoSsF4qDUmAwKbkNT9kwY/P Ml6avFcPq/RmRhFOZ7md1sIDtK+GGsJnmJ7CSZQkqUEMXQOw1eQyPozVKiJch/Es0x3j3s 6NDq+adBasHWNTc29dD+KrMdsAY8c4i3lRHScc4xfX4yqOQP/F2NJ9aVN/EtRg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1655047102; a=rsa-sha256; cv=none; b=mz4NL7LkIYod10EVkucwK2v8VRmiysGRBFir8Y3hRV8Eai7fKjDykAB1Qu9JyZOvgeVDtv pqsQlDzUJtWy5Z27pUWJLvHuFLLux/ApkPiT8bHNqCWzF9/03wBew5Nyu0JETuSCYC65N/ 37dt1isI5FwGTI8a4EWTg190RTlrqUTnd+5OUdhh5Xir0RcoxCFQFUNqEkfQWn9xxkrhrY PRrXzQfRklApp+57cCSUZqcnmv4nH2J9V3sJMi+8exctModKxbdnreSA1ESXHSCN/F4J04 CaJmEAkFWDwEBUOnJLhbSwtvo/y+nuaZsOgZBbwza8pwqQMfnF2ciZn84iduLg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --n3rvye4kcg25rgka Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2022-05-25 at 11:49 EDT, Warner Losh wrote: >On Wed, May 25, 2022 at 9:39 AM Matteo Riondato wrote: > >> On 2022-05-25 at 11:29 EDT, Warner Losh wrote:=20 >> >=20 >> >SET FEATURES (opcode 9) feature 0xb is indeed async event=20 >> >configuration.=20 >> >0x31f is:=20 >> >SMART WARNING for available spares (0x1)=20 >> >SMART warning for temperature (0x2)=20 >> >SMART WARNING for device reliability (0x4)=20 >> >SMART WARNING for being read only (0x8)=20 >> >SMART WARNING for volatile memory backup (0x10)=20 >> >Namespace attribute change events (0x100)=20 >> >Firmware activation events (0x200)=20 >> >=20 >> >I wonder which one of those it doesn't like. My reading of the standard= =20 >> >suggests that those should always be supported for a 1.2 and later=20 >> >drive... Thought maybe with the possible exception of the volatile=20 >> >memory backup, so let me do some digging here...=20 >> >=20 >> >We can get the last two items from OAES field of the controller=20 >> >identificaiton data. This is bytes 95:92, which if I'm counting right= =20 >> >is the last word on the 040: line in the nvmecontrol identify -x nvmeX= =20 >> >command:=20 >> >=20 >> >040: 4e474e4b 30303150 000cca07 00230000 00010200 005b8d80 0030d400=20 >> >00000100 >> >> >-----------------------------------------------------------------------= -----------------------------------^^^^^^^^^ >> >> On my system: >> >> 040: 31564456 30373130 5cd2e400 00000500 00010200 001e8480 002dc6c0=20 >> 00000200 >> > >Yea, 0x200 and we send 0x300, so maybe that's the cause of the message.... With the patch you sent, the message is gone from dmesg. Thank you. I didn't check (because I don't know how), but I assume that everything=20 else stayed the same. If, as you said above, these features should be supported per ithe=20 standard, but aren't, perhaps it would be worth printing a warning=20 (maybe under verbose boot)? But maybe it is too much hassle. Thanks anyway, and perhaps you may commit the patch you sent me. Thanks, Matteo --n3rvye4kcg25rgka Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAABCgAxFiEEa9uKZL0hP4E8Nl5vGwL9SVQlVQEFAmKmA68TGGhrcHM6Ly9w Z3AubWl0LmVkdQAKCRAbAv1JVCVVATd6D/wMChf63H5IFXmib1M/bS8j9H6hBt/P +/eW+dBLrOztbKJunCg8Ny3MgtnttGK+RyzmIYRCJPS+bFMWBjLsLczH19BDcBXw OyJWdADZBtTPelnydC+Z3hYJnnl1WgklZRsHoJvkls+q2JdBKS0COMf7v3tIces1 nXPQkL0MJajYs9NE/t1VCa7y7IWP0sHnnzPZZAb+488ksdY9LZ5TwLMj1hhMwWtK vciApaq4Tfgl+BLY3TuaJzA/rZPYujB2vaPQCC6s4w2WHGzYfdaRbvVUwlFjGGwV QMTKiwsld6LjbFYkrpAodXCFwQO2ax0Sg8PnFSQwFDzSVO6fgFm31DFQK9rZLiRP 6fiCNa6wvE/dSf48BSmeZRgtYmyzS2BRByD/aOgw4dB9I+SKXYvlZBLCHLasmpmp G54IQiAKsEZw1wm6vLdvkfk4Hqt7/lF5PKitOLTOKh2Qgp7E/7w6gzzKqJbTNoAM Bj6xSKToLf4B0GyI7B1h1xpuu6stzx2E6kGYVQJDWx3x+IpYzY3ejT4NlY4IYGVL FEgfFSibJ6uj+HRL9ljHSsQSeTZ/9LGMN9GB0S3HTA743WkL73ZPz/uJMQljxWbK AQQD1b4/5PtAb3hyVOcklfxGuxHcrB3fvOMwDGmGpDGGR8w8/azw/SGd+0ZJLdrc AocQp+r8ZhiDaQ== =rGdl -----END PGP SIGNATURE----- --n3rvye4kcg25rgka--