From nobody Sat Jun 04 19:34:57 2022 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id EFFFF1BEF8ED for ; Sat, 4 Jun 2022 19:35:09 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LFqhr5qjSz4VwY for ; Sat, 4 Jun 2022 19:35:08 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oi1-f171.google.com with SMTP id m82so14549309oif.13 for ; Sat, 04 Jun 2022 12:35:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QnSoRKO6M+xe8poparavlqpAVRCjWD6Ab5grtvJVC14=; b=jJTKd1Mn1xjHNXAKO/mom8l20+PLAS78QBKqgRTKhIOiLkX1/WODmp9aVq0mFyRyV1 KFufedm05zFgLjVKCqkjhz0Ym2dTl1NvgCtdDJhScvEk0jKmaE7Ke5tz9VSnvOUPjJYu BPzdDVO+xPhcm0v4UUJXAZTAkydsd1j2pD3/JVIPrxxnL1jwJF+uu+p5zyb7IyqEjFA1 pcOtK/1jy9Ugp6T/8Qp8J4/fjth3FoL7XvMXAVs3K3gc1xm6R3TiquUapNAVZLzJ1dYw j4yopQB+c9xZROG+vCgXkm9QM4k/f9lJQfHkcxmUJ2wROHyKLq22FtvgGshtzqO6OyWp YZmw== X-Gm-Message-State: AOAM5322VLKO/ADPNR/9CPXZ5BTENpMyWnquBm0Hhmkopz19NSJYYIJO 98AF/gpbcu9u8cEQMVwpcQCKngTuiwrm77E+7b87V6UH X-Google-Smtp-Source: ABdhPJysY2t8gZv1zAYGu/lNBtx445p2yajEBu2Dj+ccqTjZ5moDhDjYEvg2oEwfBf4PUKUvOIas0tNzX5uLZNLPG4M= X-Received: by 2002:a05:6808:13d0:b0:32b:d458:4979 with SMTP id d16-20020a05680813d000b0032bd4584979mr22866782oiw.72.1654371308127; Sat, 04 Jun 2022 12:35:08 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Alan Somers Date: Sat, 4 Jun 2022 13:34:57 -0600 Message-ID: Subject: Re: panic: make_dev_alias_v: bad si_name To: Warner Losh Cc: Yuri , FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4LFqhr5qjSz4VwY X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.167.171 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-2.92 / 15.00]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.987]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.94)[-0.936]; FREEFALL_USER(0.00)[asomers]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; SH_EMAIL_DBL_DONT_QUERY_IPS(0.00)[0.0.0.0:email,0.0.0.1:email]; NEURAL_HAM_LONG(-0.99)[-0.994]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[current@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DBL_PROHIBIT(0.00)[0.0.0.0:email,0.0.0.1:email]; RCVD_IN_DNSWL_NONE(0.00)[209.85.167.171:from]; MLMMJ_DEST(0.00)[current]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.167.171:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Sat, Jun 4, 2022 at 1:04 PM Warner Losh wrote: > > > > On Sat, Jun 4, 2022, 11:13 AM Yuri wrote: >> >> Getting the following panic on HPE system with HPE enclosure: >> >> panic: make_dev_alias_v: bad si_name (error=22, >> si_name=enc@n....../type@0/slot@1/elmdesc@{"Name":"DriveBay1"}/pass4) >> >> db_trace_self_wrapper() >> vpanic() >> panic() >> make_dev_alias_v() >> make_dev_alias_p() >> make_dev_physpath_alias() >> pass_add_physpath() >> taskqueue_run_locked() >> taskqueue_thread_loop() >> fork_exit() >> fork_trampoline() >> >> I have skipped typing all the frame information as the cause of panic >> seems to be apparent -- enclosure replies with "Name":"DriveBay1" via >> ses (it does the same weirdness for sensors and other elements), and >> make_dev_alias_v() does not like the double quotes. Probably we need to >> sanitize the input somewhere? > > > > Likely. I'll take a look. Can you file a bug, include CAM in the title and cc imp@ please? > > Warner Also, it would help to include the output of "sg_ses -p7 /dev/sesXXX", where sg_ses comes from sysutils/sg3_utils.