Re: BLAKE3 unstability?

(forgot to CC -CURRENT, so replying to the list)

> It did not reproduce for me with in-tree ZFS on main@3c9ad9398fcd either.
> 
> Could you share sysctl kstat.zfs.misc.chksum_bench, maybe we are using
> different implementations?
> I do see that blake3 went in with only a Linux module parameter for the
> implementation selection, so I'll have to fix that. For now we can at least
> see which was fastest, which should be the one selected. You just won't be
> able to manually change it to see if that helps.
> 
> - Ryan
 
$ sysctl kstat.zfs.misc.chksum_bench
kstat.zfs.misc.chksum_bench:
implementation     1k      4k     16k     64k    256k      1m      4m
edonr-generic    1358    1580    1642    1642    1621    1560    1525
skein-generic     238     252     256     256     256     256     254
sha256-generic    242     263     269     271     271     271     271
sha512-generic    373     416     428     430     431     431     431
blake3-generic    482     478     477     474     473     473     473
blake3-sse2       338    1403    1505    1526    1519    1504    1503
blake3-sse41      350    1602    1725    1758    1753    1747    1747
blake3-avx2       350    1874    3336    3550    3527    3492    3485
 
Could it be due to SIMD? I can try a patch. I can also try with GENERIC
kernel tomorrow as it is the only local modification left. I thought it
also could be damaged hardware, but AVX2 torture tests and memtest runs
fine.
 
Thanks for investigating this issue.