From nobody Thu Jul 07 17:00:28 2022 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0289712DD139 for ; Thu, 7 Jul 2022 17:00:32 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lf2jB4b5Fz3ZcF for ; Thu, 7 Jul 2022 17:00:30 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.16.1/8.16.1) with ESMTPS id 267H0SOm020029 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 7 Jul 2022 10:00:28 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.16.1/8.16.1/Submit) id 267H0SFb020028; Thu, 7 Jul 2022 10:00:28 -0700 (PDT) (envelope-from sgk) Date: Thu, 7 Jul 2022 10:00:28 -0700 From: Steve Kargl To: Warner Losh Cc: Ryan Stone , FreeBSD Current Subject: Re: buildkernel is broken Message-ID: Reply-To: sgk@troutmask.apl.washington.edu References: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4Lf2jB4b5Fz3ZcF X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=washington.edu (policy=none); spf=none (mx1.freebsd.org: domain of sgk@troutmask.apl.washington.edu has no SPF policy when checking 128.95.76.21) smtp.mailfrom=sgk@troutmask.apl.washington.edu X-Spamd-Result: default: False [-1.00 / 15.00]; NEURAL_HAM_SHORT(-1.00)[-0.998]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[washington.edu : No valid SPF, No valid DKIM,none]; MIME_TRACE(0.00)[0:+]; R_SPF_NA(0.00)[no SPF record]; ASN(0.00)[asn:73, ipnet:128.95.0.0/16, country:US]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current]; FREEMAIL_CC(0.00)[gmail.com,freebsd.org]; R_DKIM_NA(0.00)[]; TO_DN_ALL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; RCVD_COUNT_THREE(0.00)[3]; HAS_REPLYTO(0.00)[sgk@troutmask.apl.washington.edu] X-ThisMailContainsUnwantedMimeParts: N On Thu, Jul 07, 2022 at 10:37:40AM -0600, Warner Losh wrote: > On Thu, Jul 7, 2022 at 10:37 AM Steve Kargl < > sgk@troutmask.apl.washington.edu> wrote: > > > Thanks, but > > > > root[216] git cherry-pick -n 37f604b49d4a > > fatal: bad revision '37f604b49d4a' > > root[217] pwd > > /usr/src > > > git fetch maybe? > A cursory google search suggests that 'git fetch' works on repositories not single files. I did look at the diff associated with 37f604b49d4a. I am surprised that the commit that broke buildkernel for me was allowed to be committed. The fix in 37f604b49d4a seems rather questionable especially given that there is no comment about why the macro is expanded to a zero-trip loop. Thanks for the help. I'll just do a 'git pull' and start over with a buildworld. -- Steve