From nobody Fri Sep 03 20:48:47 2021 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 57D141799F98 for ; Fri, 3 Sep 2021 20:48:57 +0000 (UTC) (envelope-from tsoome@me.com) Received: from pv50p00im-hyfv10011601.me.com (pv50p00im-hyfv10011601.me.com [17.58.6.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4H1VJT1MTXz3mD7 for ; Fri, 3 Sep 2021 20:48:57 +0000 (UTC) (envelope-from tsoome@me.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1630702130; bh=zm5pjeo2u6uuURsWqJk7nAQsuZrarg5+4dD4P3yVZd4=; h=Content-Type:Mime-Version:Subject:From:Date:Message-Id:To; b=0iepCsi8U1mmt4smUZpMghUYfRh28OjPL1/Hd8BuR68Bd9YOAYWIC7EMA0pw3qXyo UKk10+5c0YPY2Py8fwtnT0j8Y4mMdzK+Sm84GYYhdTLoOXvuMVyZv0Y7pz2Sb0i7ga FXkftm52pdYOsaJBBvr8102fdcqVEGolujAUVpBUIa1Dt2x8fQJUiCdeiNxhagJXJA wT3/gyCcC3dIuDORyuXZbxCLRERK0UnSDv6shTOnLE+DUWRz5KgM8Vfi0b1Z5oMv7i Tcbuh5etwNRwtFgM0DhET913LBV1zJjJ8baYgpAZBr0kcH7GKk2GMh8FqTuC3s3IVK LplkOeMGX8GrA== Received: from smtpclient.apple (148-52-235-80.sta.estpak.ee [80.235.52.148]) by pv50p00im-hyfv10011601.me.com (Postfix) with ESMTPSA id 848FE3802B4; Fri, 3 Sep 2021 20:48:49 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: FreeBSD-13-STABLE: lib/libsecureboot/verify_file.c: error: use of undeclared identifier 'SOPEN_MAX' In-Reply-To: <20210903180022.41ad35ae@thor.intern.walstatt.dynvpn.de> Date: Fri, 3 Sep 2021 23:48:47 +0300 Cc: FreeBSD CURRENT Content-Transfer-Encoding: quoted-printable Message-Id: <18682E1D-E64A-4F02-8949-491763DCD9A2@me.com> References: <20210903180022.41ad35ae@thor.intern.walstatt.dynvpn.de> To: FreeBSD User X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-09-03_07:2021-09-03,2021-09-03 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2009150000 definitions=main-2109030121 X-Rspamd-Queue-Id: 4H1VJT1MTXz3mD7 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Reply-To: tsoome@me.com From: Toomas Soome via freebsd-current X-Original-From: Toomas Soome X-ThisMailContainsUnwantedMimeParts: N > On 3. Sep 2021, at 18:59, FreeBSD User wrote: >=20 > Hello, >=20 > enabling=20 >=20 > WITH_BEARSSL=20 >=20 > in src.conf renders buildworld on 13-STABLE to fail, but not on > 14-CURRENT.=20 >=20 >=20 >=20 > This is the difference between the sources, obviously 14-CURRENT = contains the correct > definition of SOPEN_MAX, while 13-STABLE not (undefinied SOPNE_MAX = triggers the compiler to > fail,=20 > /usr/src/lib/libsecureboot/verify_file.c:59:22: error: use of = undeclared identifier > 'SOPEN_MAX'), see >=20 > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D258211 >=20 >=20 > [...] > 13-STABLE > :/pool/sources/13-STABLE/src # grep -r SOPEN_MAX . > ./lib/libsecureboot/tests/Makefile:XCFLAGS.verify_file +=3D = -DSOPEN_MAX=3D64 > ./lib/libsecureboot/verify_file.c:static int ve_status[SOPEN_MAX+1]; > ./lib/libsecureboot/verify_file.c: if (fd >=3D 0 && fd < = SOPEN_MAX) { > ./lib/libsecureboot/verify_file.c: ve_status[SOPEN_MAX] =3D ves; > ./lib/libsecureboot/verify_file.c: * @li ve_status[SOPEN_MAX] if = ve_status_state is none > ./lib/libsecureboot/verify_file.c: fd >=3D 0 && fd < = SOPEN_MAX) > ./lib/libsecureboot/verify_file.c: return (ve_status[SOPEN_MAX]); = /* most recent */ >=20 > [...] > 14-CURRENT > ./lib/libsecureboot/tests/Makefile:XCFLAGS.verify_file +=3D = -DSOPEN_MAX=3D64 > ./lib/libsecureboot/verify_file.c:#ifndef SOPEN_MAX > ./lib/libsecureboot/verify_file.c:#define SOPEN_MAX 64 > ./lib/libsecureboot/verify_file.c:static int ve_status[SOPEN_MAX+1]; > ./lib/libsecureboot/verify_file.c: if (fd >=3D 0 && fd < = SOPEN_MAX) { > ./lib/libsecureboot/verify_file.c: ve_status[SOPEN_MAX] =3D ves; > ./lib/libsecureboot/verify_file.c: * @li ve_status[SOPEN_MAX] if = ve_status_state is none > ./lib/libsecureboot/verify_file.c: fd >=3D 0 && fd < = SOPEN_MAX) > ./lib/libsecureboot/verify_file.c: return (ve_status[SOPEN_MAX]); = /* most recent */ >=20 >=20 >=20 >=20 > --=20 > O. Hartmann >=20 Hi! Sorry, it is fixed now. Missed one cherry-pick. rgds, toomas=