From nobody Fri Sep 03 15:59:55 2021 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2B61F17B128C for ; Fri, 3 Sep 2021 16:00:32 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Received: from smtp4-2.goneo.de (smtp4.goneo.de [IPv6:2001:1640:5::8:59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4H1Mvg3kzTz4s7Q for ; Fri, 3 Sep 2021 16:00:31 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Received: from thor.intern.walstatt.dynvpn.de (dynamic-077-011-197-020.77.11.pool.telefonica.de [77.11.197.20]) by smtp4.goneo.de (Postfix) with ESMTPSA id 821A92005553 for ; Fri, 3 Sep 2021 18:00:23 +0200 (CEST) Date: Fri, 3 Sep 2021 17:59:55 +0200 From: FreeBSD User To: FreeBSD CURRENT Subject: FreeBSD-13-STABLE: lib/libsecureboot/verify_file.c: error: use of undeclared identifier 'SOPEN_MAX' Message-ID: <20210903180022.41ad35ae@thor.intern.walstatt.dynvpn.de> Organization: walstatt-de.de List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4H1Mvg3kzTz4s7Q X-Spamd-Bar: ++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd@walstatt-de.de has no SPF policy when checking 2001:1640:5::8:59) smtp.mailfrom=freebsd@walstatt-de.de X-Spamd-Result: default: False [2.39 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[walstatt-de.de]; AUTH_NA(1.00)[]; RCPT_COUNT_ONE(0.00)[1]; HAS_ORG_HEADER(0.00)[]; NEURAL_SPAM_MEDIUM(0.99)[0.995]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.44)[-0.444]; NEURAL_SPAM_LONG(0.94)[0.944]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; ASN(0.00)[asn:25394, ipnet:2001:1640::/32, country:DE]; RCVD_TLS_ALL(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[77.11.197.20:received] X-ThisMailContainsUnwantedMimeParts: N Hello, enabling WITH_BEARSSL in src.conf renders buildworld on 13-STABLE to fail, but not on 14-CURRENT. This is the difference between the sources, obviously 14-CURRENT contains the correct definition of SOPEN_MAX, while 13-STABLE not (undefinied SOPNE_MAX triggers the compiler to fail, /usr/src/lib/libsecureboot/verify_file.c:59:22: error: use of undeclared identifier 'SOPEN_MAX'), see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258211 [...] 13-STABLE :/pool/sources/13-STABLE/src # grep -r SOPEN_MAX . ./lib/libsecureboot/tests/Makefile:XCFLAGS.verify_file += -DSOPEN_MAX=64 ./lib/libsecureboot/verify_file.c:static int ve_status[SOPEN_MAX+1]; ./lib/libsecureboot/verify_file.c: if (fd >= 0 && fd < SOPEN_MAX) { ./lib/libsecureboot/verify_file.c: ve_status[SOPEN_MAX] = ves; ./lib/libsecureboot/verify_file.c: * @li ve_status[SOPEN_MAX] if ve_status_state is none ./lib/libsecureboot/verify_file.c: fd >= 0 && fd < SOPEN_MAX) ./lib/libsecureboot/verify_file.c: return (ve_status[SOPEN_MAX]); /* most recent */ [...] 14-CURRENT ./lib/libsecureboot/tests/Makefile:XCFLAGS.verify_file += -DSOPEN_MAX=64 ./lib/libsecureboot/verify_file.c:#ifndef SOPEN_MAX ./lib/libsecureboot/verify_file.c:#define SOPEN_MAX 64 ./lib/libsecureboot/verify_file.c:static int ve_status[SOPEN_MAX+1]; ./lib/libsecureboot/verify_file.c: if (fd >= 0 && fd < SOPEN_MAX) { ./lib/libsecureboot/verify_file.c: ve_status[SOPEN_MAX] = ves; ./lib/libsecureboot/verify_file.c: * @li ve_status[SOPEN_MAX] if ve_status_state is none ./lib/libsecureboot/verify_file.c: fd >= 0 && fd < SOPEN_MAX) ./lib/libsecureboot/verify_file.c: return (ve_status[SOPEN_MAX]); /* most recent */ -- O. Hartmann