Re: git: 2f7f8995367b - main - libdialog: Bump shared library version to 10. [ the .so.10 is listed in mk/OptionalObsoleteFiles.inc ?]

From: John Baldwin <jhb_at_FreeBSD.org>
Date: Wed, 27 Oct 2021 23:58:45 UTC
On 10/27/21 3:23 PM, Mark Millard via freebsd-current wrote:
> 
> 
> On 2021-Oct-27, at 15:21, Mark Millard <marklmi@yahoo.com> wrote:
> 
>> Unfortunately(?) this update added the .so.10 to mk/OptionalObsoleteFiles.inc :
>>
>> diff --git a/tools/build/mk/OptionalObsoleteFiles.inc b/tools/build/mk/OptionalObsoleteFiles.inc
>> index a8b0329104c4..91822aac492a 100644
>> --- a/tools/build/mk/OptionalObsoleteFiles.inc
>> +++ b/tools/build/mk/OptionalObsoleteFiles.inc
>> _at__at_ -1663,11 +1663,11 _at__at_ OLD_FILES+=usr/bin/dialog
>> . . .
>> OLD_FILES+=usr/lib/libdialog.so
>> -OLD_FILES+=usr/lib/libdialog.so.8
>> +OLD_FILES+=usr/lib/libdialog.so.10
>> . . .
>>
>> Looks to my like that +line should have been:
>>
>> +OLD_FILES+=usr/lib/libdialog.so.9
>>
>> (presuming the original .so.8 was correct during
>> .so.9 's time frame).
> 
> 
> Looks like:
> 
> +OLD_FILES+=usr/lib/libdpv.so.3
> 
> is the same sort of issue and possibly should have been:
> 
> +OLD_FILES+=usr/lib/libdpv.so.2

No, these lines are for removing the current versions of the
libraries if you do 'make delete-old WITHOUT_DIALOG=yes'.

They weren't bumped previously when I bumped them for ncurses
(probably my fault).

-- 
John Baldwin