From nobody Mon Nov 01 09:19:48 2021 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 51B9418452C8; Mon, 1 Nov 2021 09:19:59 +0000 (UTC) (envelope-from SRS0=42hC=PU=quip.cz=000.fbsd@elsa.codelab.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [94.124.105.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4HjSDG6nmCz3RHY; Mon, 1 Nov 2021 09:19:58 +0000 (UTC) (envelope-from SRS0=42hC=PU=quip.cz=000.fbsd@elsa.codelab.cz) Received: from elsa.codelab.cz (localhost [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id 64B4428411; Mon, 1 Nov 2021 10:19:51 +0100 (CET) Received: from illbsd.quip.test (ip-78-45-215-131.net.upcbroadband.cz [78.45.215.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id B809228417; Mon, 1 Nov 2021 10:19:49 +0100 (CET) Subject: Re: Deprecating smbfs(5) and removing it before FreeBSD 14 To: Yuri , freebsd-current@freebsd.org, freebsd-stable References: <6f99f9bc-8831-aefe-4f73-72f50f8f347b@aetern.org> From: Miroslav Lachman <000.fbsd@quip.cz> Message-ID: <79402464-f9e6-5f56-645e-cfd49640032e@quip.cz> Date: Mon, 1 Nov 2021 10:19:48 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 In-Reply-To: <6f99f9bc-8831-aefe-4f73-72f50f8f347b@aetern.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4HjSDG6nmCz3RHY X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On 01/11/2021 09:36, Yuri wrote: > Ed Maste wrote: >> The smbfs(5) filesystem supports only the obsolete SMBv1 protocol, and >> I propose removing it for FreeBSD 14. I know the CHERI folks have been >> using it but they plan to migrate away from it. It was broken for >> months before they fixed it, so I suspect nobody is using it on >> contemporary releases. >> >> I have review D32707 (https://reviews.freebsd.org/D32707) open to add >> this deprecation notice to the man page: >> The smbfs filesystem driver supports only the obsolete SMBv1 protocol. >> smbfs and userspace counterparts smbutil(1) and mount_smbfs(8) are not >> present in FreeBSD 14 and above. Users are advised to evaluate the >> sysutils/fusefs-smbnetfs port instead. >> >> A similar notice would be added to the smbutil and mount_smbfs man >> pages, and manu@ suggested having the userland utilities emit a >> warning when they are used. >> >> I am interested in comments, objections, or reports that anyone is in >> fact using smbfs. > > I thought I'd mention the SMB client in illumos which is originally > based on FreeBSD one, imported and enhanced by Apple, then imported by > Sun, and finally updated to support SMB2/SMB3 in illumos. It has a lot > of CDDL code now, but as ZFS shows it's not really a stopper. > > ISTR there is (was?) also an Apple SMB client (based on FreeBSD) > somewhere on their "opensource" site. > > Just saying that there are other options if someone(TM) is interested in > doing the work. Apple sources can be found there https://opensource.apple.com/source/smb/ with all the history from SMBv1 to SMBv3. The files have original copyright header from 2001 Boris Popov (same as FreeBSD) but otherwise it is very different code due to different kernel interfaces and so on. With Apple and Illumos sources it is possible to have smbfs in FreeBSD upgraded to v2 or v3 but very skilled programmer is needed for this work. And for the past years there is none interested in this work. Miroslav Lachman