From nobody Mon May 31 03:42:15 2021 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 43E8CC7B9A1 for ; Mon, 31 May 2021 03:42:27 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Fth1v17qKz3GyF for ; Mon, 31 May 2021 03:42:26 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82a.google.com with SMTP id a15so7149403qta.0 for ; Sun, 30 May 2021 20:42:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jTBKpMmiHrVob6GnH+hWSehdqVPzAmIcTvmq5oUtOqo=; b=Qu9GhZTsETrF7oWtUEMecjciZ2cuMLgvUA1LgGaCVMd6gmC1gQmjBU7E737KBamh2u jOcBi4MwnF7PPNYCd88HQ0Ov1zIMmP6rIaZxfCl3WPEydAgNNzjvibBBVN+x0YyXD7pj HuZFoaVXl1j6lIzx8A1MjrxBSfzpT8inWzhTWK+vDN/8fMpSp06FSd1qdS0bqpct5jR/ hQzGQr/RPHQIETlGUnXFdUx3Lgnv2qc8s8HAR/FMhY+ob2IoqjCIRkx+sIiOj2+Z1cAf 2H3wKMEABOnQdVnsgAY/jRnc2JiCmzyRGJfnTGwUMs1oQAs1goz6NMz2XcWJi9tkAtpT FE9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jTBKpMmiHrVob6GnH+hWSehdqVPzAmIcTvmq5oUtOqo=; b=JoNkZwG9GGjQEqROtEpOdUa5Ch72R+zBhw7H7VFtSW0V6O5fkAHDGc4pQ+qNIqUhHO 0qM1ZQgA5GxVLe/nMhU5/Mn8dWDeYIkuBbe7DZrYrK3TqSdz3y76H0rIS1DbZDeTc+Sp 5o7JWN9OX4C70mJOHrdRVjP6kd2RRmaBzCTYnERDfDWppM8hiPTgjDBZwMf66CMEu/c8 pRxCiRe2uDhMEy8UsK6Vs77Rajis3JSch5lgcfCcOnrrtcopBhlkcXoKtV9cLf+CNBOh WeZD3ohSkUkPMHzA2QxRSbbAZNVSzL2R4qY9dhMnjWIBrspIdhQAklgOI1ctIfHOmoQV SGlw== X-Gm-Message-State: AOAM53035rbWshiUADz8rOvp1y0FJF99Oax26JGxnrFw+V0C9mJXXX0l iEbag6kWAmYHdwKmQ3lFgDBwWt2dcm/Bac61DT27Ig== X-Google-Smtp-Source: ABdhPJyE8dWd6M1f6BLzgPGnAMrlrdLI1mxNJ+0rwkRvl6AMXa2YKe7+fOz6fZQ0esbVxOScNzthdIPxqUBUMEweL2c= X-Received: by 2002:ac8:7f42:: with SMTP id g2mr13265510qtk.73.1622432546253; Sun, 30 May 2021 20:42:26 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: <088c1df0-6d37-b5b8-c194-3f89a79b80c4@FreeBSD.org> In-Reply-To: <088c1df0-6d37-b5b8-c194-3f89a79b80c4@FreeBSD.org> From: Warner Losh Date: Sun, 30 May 2021 21:42:15 -0600 Message-ID: Subject: Re: Help wanted: volunteer yourselves in .github/CODEOWNERS To: Kubilay Kocak Cc: Alan Somers , FreeBSD CURRENT , Adrian Chadd , Randall Stewart , Rick Macklem Content-Type: multipart/alternative; boundary="0000000000009782f505c39803b1" X-Rspamd-Queue-Id: 4Fth1v17qKz3GyF X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; TAGGED_RCPT(0.00)[]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: Y --0000000000009782f505c39803b1 Content-Type: text/plain; charset="UTF-8" On Sun, May 30, 2021 at 8:17 PM Kubilay Kocak wrote: > On 31/05/2021 9:13 am, Alan Somers wrote: > > Strangers are submitting pull requests to our Github mirror, but we > rarely > > pay attention. I just added a .github/CODEOWNERS file to our repo to > > automatically assign reviewers to PRs. I based it off of the contents of > > the current MAINTAINERS file. But it's incomplete. Please add yourself > if: > > > > * You don't have a github account associated with your FreeBSD email > > address. I'm talking to you, adrian@, macklem@, and rrs@ . > > * You are part of a team, like secteam@ or re@ . You'll have to create > the > > team at https://github.com/orgs/freebsd/teams then you can add it to the > > list. > > * You previously signed up for Phabricator notifications with Herald, but > > didn't sign up in MAINTAINERS. I can't see everybody's Phabricator > > assignments. > > * You never signed up in MAINTAINERS before, but you really ought to > > because you care deeply about some particular subsystem. > > > > -Alan > > > > Thanks for this Alan. > > Bugmeister is (and has been for a while) also keen to finally solve the > problem of better getting the right eyes on patches submitted to > Bugzilla for particular code areas, which complements other areas of > improvements in issue management, such as more and clearer components in > Bugzilla for people to use. > > Ports has an explicit MAINTAINER line we use to automatically > auto-assign and CC issues, it would be great to use CODEOWNERS for this, > along with appropriate consistently declared MAINTAINER lines in > specific component directories and/or Makefiles. > > I think this is a good time to raise the difficult question/issue of > policy/guidelines around code maintainership and responsibilities around > that, including: > > - Having one or more maintainers of tree areas/components > - Maintainer review, approval and timeouts > - Issue triage/management > Before I start, I'd like to note what we do today isn't working. We have a lot of intake points and it's hard to find things for developers. We need to do something different to help tame the chaos. The src tree and the ports tree are somewhat different in terms of all these issues. Some parts of the tree require proper oversight by a small group of experts (regardless of timeout), while other parts of the tree need less oversight. Some parts of the tree you can get a good notion of who should get reports of bugs based on who has made recent changes (though API sweeps can skew the results). Other parts of the tree the changes are far enough in the past to be a poor judge. I suspect that a combination of what we've done in the past, coupled with some shifts with roles as the project modernizes and liberalizes. Whatever we put into place will need to grow with us. Finally, we've had a poor history of maintaining long lists of maintainers, so I suspect we'll need to have some kind of automation involved to keep things fresh enough to be useful. Warner --0000000000009782f505c39803b1--