From nobody Mon May 31 02:16:48 2021 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id B01ABBFE991 for ; Mon, 31 May 2021 02:16:54 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ftf7B41V3z4t9y; Mon, 31 May 2021 02:16:54 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pf1-x42f.google.com with SMTP id x73so657776pfc.8; Sun, 30 May 2021 19:16:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=2Zf6m9Xdchtx7sEJOOQxdjoOOE5xfeQuMDQYRQmnSdY=; b=OFve8TQrwlBhiedgI3mIz3nW08CL7Gm9ctO1Qrvu4xFfnRntq04xjb+EvefLM+mrsa aB456JxQxZv7tB6ve1eCpilN6HJpJpwqh9s2iqIGZNIDiC4P+HG/Xryi7NVF1DDu//L9 lbkxDp3ZR6bebn6TiQev6Yp2hktIXQa1z9kYxX+zQdihxyNCFZTHqEKR+/GU3DluM1zE FAxZLzQJ3ZPxeBOA3Ib4RIedqeyNMbGKbDwJ5J0z1Mai1uag1ElXkCmsGa5tOaJzG0po pg1Madx1TLYSMNY0eE7XdqRiBFMGroLNi0EoOIerwVD0IwQ0vjg9qUPBtzzfCRYaVdLx SRLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :reply-to:subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=2Zf6m9Xdchtx7sEJOOQxdjoOOE5xfeQuMDQYRQmnSdY=; b=ioC/A22kt1Ei+QEbdPw88DAhz0uYrv7VWcwLXvLw0RcuaYotzUpQNuNWaHXkBB9JLH dxKhZ6romRxwtbpTK35InbqXRQgg5zgBunw+C9rbKvGuwcX3fx9xoBVBcFRmcZPi20qo x+SlfI/m9lY1n9aDkFmJKN0CSgKZ6PVaCdtH+t54iymA0xYc15UayaLGsFjNboVWjYuL Wd/PJkJSHgfpyq170a2wc/iJjom2hHFaGAwyAB9igrQ36JkVN9eqegN1l3h53inz6jTV UDe/faZ98CBldjlxuvqzV4RIATD6qQczTdZZGCx8Ga+U7Z+u1Q1y/pZp9sCz9/sT36hv ZCpw== X-Gm-Message-State: AOAM530wOcXFNgOZlOWVsZYQBNtG4yimAqGBoGI5VSp1JgIEaFW7DzUH /tBlXgTeukcvikVQe5lKFOh0sqWpxo3USw== X-Google-Smtp-Source: ABdhPJzLUYWWcmv53qA1YVUy/4o89fzo+RVWTZZ2oeAbxTIKtzDZNy6bejRm3dSP8AaKEjrodUgo7A== X-Received: by 2002:a62:a517:0:b029:2dc:9daf:5e91 with SMTP id v23-20020a62a5170000b02902dc9daf5e91mr14829907pfm.39.1622427412427; Sun, 30 May 2021 19:16:52 -0700 (PDT) Received: from ?IPV6:2403:5800:7500:3601:7d0d:18fb:cdf3:35cc? (2403-5800-7500-3601-7d0d-18fb-cdf3-35cc.ip6.aussiebb.net. [2403:5800:7500:3601:7d0d:18fb:cdf3:35cc]) by smtp.gmail.com with UTF8SMTPSA id t1sm10073046pgl.40.2021.05.30.19.16.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 May 2021 19:16:52 -0700 (PDT) Message-ID: <088c1df0-6d37-b5b8-c194-3f89a79b80c4@FreeBSD.org> Date: Mon, 31 May 2021 12:16:48 +1000 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Thunderbird/90.0a1 Reply-To: koobs@FreeBSD.org Subject: Re: Help wanted: volunteer yourselves in .github/CODEOWNERS Content-Language: en-US To: Alan Somers , FreeBSD CURRENT , Adrian Chadd , rrs@freebsd.org, Rick Macklem References: From: Kubilay Kocak In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Ftf7B41V3z4t9y X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; TAGGED_RCPT(0.00)[]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On 31/05/2021 9:13 am, Alan Somers wrote: > Strangers are submitting pull requests to our Github mirror, but we rarely > pay attention. I just added a .github/CODEOWNERS file to our repo to > automatically assign reviewers to PRs. I based it off of the contents of > the current MAINTAINERS file. But it's incomplete. Please add yourself if: > > * You don't have a github account associated with your FreeBSD email > address. I'm talking to you, adrian@, macklem@, and rrs@ . > * You are part of a team, like secteam@ or re@ . You'll have to create the > team at https://github.com/orgs/freebsd/teams then you can add it to the > list. > * You previously signed up for Phabricator notifications with Herald, but > didn't sign up in MAINTAINERS. I can't see everybody's Phabricator > assignments. > * You never signed up in MAINTAINERS before, but you really ought to > because you care deeply about some particular subsystem. > > -Alan > Thanks for this Alan. Bugmeister is (and has been for a while) also keen to finally solve the problem of better getting the right eyes on patches submitted to Bugzilla for particular code areas, which complements other areas of improvements in issue management, such as more and clearer components in Bugzilla for people to use. Ports has an explicit MAINTAINER line we use to automatically auto-assign and CC issues, it would be great to use CODEOWNERS for this, along with appropriate consistently declared MAINTAINER lines in specific component directories and/or Makefiles. I think this is a good time to raise the difficult question/issue of policy/guidelines around code maintainership and responsibilities around that, including: - Having one or more maintainers of tree areas/components - Maintainer review, approval and timeouts - Issue triage/management