From nobody Thu Jun 03 14:04:33 2021 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id A1F2CBFB490 for ; Thu, 3 Jun 2021 14:04:41 +0000 (UTC) (envelope-from freebsd@grem.de) Received: from mail.evolve.de (mail.evolve.de [213.239.217.29]) (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.evolve.de", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FwnhS4J7yz3N0l; Thu, 3 Jun 2021 14:04:40 +0000 (UTC) (envelope-from freebsd@grem.de) Received: by mail.evolve.de (OpenSMTPD) with ESMTP id f3fbe54c; Thu, 3 Jun 2021 14:04:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=grem.de; h=date:from:to:cc :subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=20180501; bh=3QO5cWBn Tc3XBs8ldWVYZeWHyw4=; b=VnFkqyS1b8gXSE+QKDpwXksX/dYMKfZIyUP2q22n pgZoqfJ5uT3fwDgcQNdELbyxOSvHhhWQZu1MGBwDmeMiubMFTt7G38AexDIPFNf2 mq/qSCICKB8CJj47fLIYuOoRybRzUOviB6fDdwLubjByRaFNCK7sG1nZvSkYtej7 3INOnXQ9N07bX1hFoP0yaJO0bTQizOF44DCLw8SxgNQQKEyQHvdOPjKqiYecefvi BD0AvSOO52QlVH0tJUeFq+WiGxGT7HseL6xkfS5/2xUJBZwYGKA+woKbu2XhXNdy ku6RYZvWmM0Ob8a0NnX7ipThu9DYJ9wAi+2nieTFhIfUag== DomainKey-Signature: a=rsa-sha1; c=nofws; d=grem.de; h=date:from:to:cc :subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; q=dns; s=20180501; b=Zv 4r/q9SvKwEkRlMhUkQtrWQNxjZLjYVfM8w0CtxK71JlVMJI+UKR89Y7a+qDTGYIV PpZC22pyZS6bUOYz9pWPaLx6tODD3hEOFLhqfiCEO6lzKY0wee5own8T1IhmFhI0 ogP3tkewawOxMRg7efQGkA4vzmi0XPyabAjhfH6gYOuxCiDO6cNYpOO5S5/VBK63 GabE+HXkDkYxg0Ouw1RF/Nqk7LcKACbJKzVnzfU06cBOTE79iHAvEWV29mkLPP8n oI6UzMmUwKmiDz9Ty/rwqlgin81LX7fHE5s1xYMZeTO2GF+bO98uG6cJUr1AMByf Bc2rmgkIJJg45ZqosqMw== Received: by mail.evolve.de (OpenSMTPD) with ESMTPSA id 50f6b7ce (TLSv1.3:AEAD-CHACHA20-POLY1305-SHA256:256:NO); Thu, 3 Jun 2021 14:04:36 +0000 (UTC) Date: Thu, 3 Jun 2021 16:04:33 +0200 From: Michael Gmelin To: Mathieu Arnold Cc: Michael Gmelin , Kurt Jaeger , current@freebsd.org Subject: Re: zpool upgrade and bootcode on 13-RELEASE Message-ID: <20210603160433.14371bea@bsd64.grem.de> In-Reply-To: <20210528205052.1c464a8f@bsd64.grem.de> References: <20210519153757.4e00e96f@bsd64.grem.de> <20210519193243.3fd82d19@bsd64.grem.de> <20210528183714.7xbmuouxlxxy3n6j@aching.in.mat.cc> <20210528205052.1c464a8f@bsd64.grem.de> X-Face: $wrgCtfdVw_H9WAY?S&9+/F"!41z'L$uo*WzT8miX?kZ~W~Lr5W7v?j0Sde\mwB&/ypo^}> +a'4xMc^^KroE~+v^&^#[B">soBo1y6(TW6#UZiC]o>C6`ej+i Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWJBwe5BQDl LASZU0/LTEWEfHbyj0Txi32+sKrp1Mv944X8/fm1rS+cAAAACXBIWXMAAAsTAAAL EwEAmpwYAAAAB3RJTUUH3wESCxwC7OBhbgAAACFpVFh0Q29tbWVudAAAAAAAQ3Jl YXRlZCB3aXRoIFRoZSBHSU1QbbCXAAAAAghJREFUOMu11DFvEzEUAGCfEhBVFzuq AKkLd0O6VrIQsLXVSZXoWE5N1K3DobBBA9fQpRWc8OkWouaIjedWKiyREOKs+3PY fvalCNjgLVHeF7/3bMtBzV8C/VsQ8tecEgCcDgrzjekwKZ7TwsJZd/ywEKwwP+ZM 8P3drTsAwWn2mpWuDDuYiK1bFs6De0KUUFw0tWxm+D4AIhuuvZqtyWYeO7jQ4Aea 7jUqI+ixhQoHex4WshEvSXdood7stlv4oSuFOC4tqGcr0NjEqXgV4mMJO38nld4+ xKNxRDon7khyKVqY7YR4d+Cg0OMrkWXZOM7YDkEfKiilCn1qYv4mighZiynuHHOA Wq9QJq+BIES7lMFUtcikMnkDGHUoncA+uHgrP0ctIEqfwLHzeSo+eUA66AqzwN6n 2ZHJhw6Qh/PoyC/QENyEyC/AyNjq74Bs+3UH0xYwzDUC4B97HgLocg1QLYgDDO1v f3UX9Y307Ew4AHh67YAFFsxEpkXwpXY3eIgMhAAE3R19L919nNnuD2wlPcDE3UeT L2ytEICQib9BXgS2fU8PrD82ToYO1OEmMSnYTjSqSv9wdC0tPYC+rQRQD9ESnldF CyqfmiYW+tlALt8gH2xrMdC/youbjzPXEun+/ReXsMCDyve3dZc09fn2Oas8oXGc Jj6/fOeK5UmSMPmf/jL+GD8BEj0k/Fn6IO4AAAAASUVORK5CYII= List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4FwnhS4J7yz3N0l X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=grem.de header.s=20180501 header.b=VnFkqyS1; dmarc=none; spf=pass (mx1.freebsd.org: domain of freebsd@grem.de designates 213.239.217.29 as permitted sender) smtp.mailfrom=freebsd@grem.de X-Spamd-Result: default: False [-3.50 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[grem.de:s=20180501]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:213.239.217.29/32]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[grem.de]; NEURAL_HAM_LONG(-1.00)[-1.000]; SPAMHAUS_ZRD(0.00)[213.239.217.29:from:127.0.2.255]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[grem.de:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[213.239.217.29:from]; ASN(0.00)[asn:24940, ipnet:213.239.192.0/18, country:DE]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[current] X-ThisMailContainsUnwantedMimeParts: N On Fri, 28 May 2021 20:50:52 +0200 Michael Gmelin wrote: > On Fri, 28 May 2021 20:37:14 +0200 > Mathieu Arnold wrote: > > > On Wed, May 19, 2021 at 07:32:43PM +0200, Michael Gmelin wrote: > > > > > > > > > On Wed, 19 May 2021 19:09:06 +0200 > > > Kurt Jaeger wrote: > > > > > > > Hi! > > > > > > > > > Does this mean, re-installing the bootcode isn't necessary > > > > > anymore > > > > > - or has the warning been removed by accident/as a side effect > > > > > of merging with OpenZFS? > > > > > > > > On the contrary, because of the switch from FreeBSD ZFS to > > > > OpenZFS, the bootcodes needs to be updated! It's unfortunate > > > > that no message is displayed 8-( > > > > > > > > > > That's too bad - maybe it would make sense to mention this in the > > > release errata? > > > > > > > The problem is, finding out which bootcode needs to go where > > > > etc. > > > > > > For the machines in question it was a straightforward legacy > > > layout, so that was easy enough (they came back up just fine - > > > *phew*). > > > > > > Do you think there is any chance to get the warning back in there? > > > Maybe in a more generic way, like: > > > > > > In case you're booting from , please make sure to > > > update the bootcode according to your partition layout. See `man > > > zfsboot' for details. > > > > > > Fun fact: That man page already exists (I had no idea), but could > > > use some love - e.g., add the EFI examples you gave. > > > > I have had a look at that man page, it gives ten different commands, > > without saying which you need to use, if they are all needed, or > > not, or when you actually have to used them. > > > > Fun fact is that I absolutely never ever used any of them. All I > > ever did was run: > > > > gpart bootcode -b /boot/pmbr -p /boot/gptzfsboot -i 1 ada1 > > > > because `zpool upgrade` told me to. It would probably be great to > > have that command in that man page. > > > > Hi Mathieu, > > I opened a pull request upstream. It already has been reviewed and > accepted, but is yet to be merged: > https://github.com/openzfs/zfs/pull/12104 > > The bootcode warning is now only shown for pools that have bootfs set > (which should be fine on most "normal" installations) and reads like > this: > > Pool 'testpool8' has the bootfs property set, you might need to > update the boot code. See gptzfsboot(8) and loader.efi(8) for details. > > I figured that these are the most relevant man pages for current > systems. It would make sense to update these man pages to be more > helpful (latest, when this change lands in FreeBSD, but earlier > obviously won't hurt). The pull request has been merged upstream: https://github.com/openzfs/zfs/commit/65d9212aeeb531e9f987bb41a1ee11b526d2cdad I'll continue tracking the issue (backporting it to 13?) at our end: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256024 Best Michael -- Michael Gmelin