From nobody Wed Jul 07 11:29:08 2021 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3E3EA7CFF2E for ; Wed, 7 Jul 2021 11:29:12 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GKcdM2s8kz4hpj for ; Wed, 7 Jul 2021 11:29:11 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-ej1-x635.google.com with SMTP id hc16so2682520ejc.12 for ; Wed, 07 Jul 2021 04:29:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:reply-to:mime-version :content-transfer-encoding; bh=IMI2wMwkjGBuhCKQPX7Bv66fQJz6nW5T373vF4VScoU=; b=H1Dk1XrAhRsxXp4Eot+sC/Nl6jJlrAZ03X7rjWYX6gvk6fRnC9iYXoTGyttLkBnse5 Jf5ga0vgcSkOM0ynALVVVtESR/2w2L94cwF8GjWF68nEo3g4XPUqPzOpRGi8CoyrVprt W6LOBwpZVdpCDjo+E2cK5l0NZv44iZjaawK8J3BKwypEwxy0uNJVNxZyGilT3PjyLsaV mYC7YmG5mCo++7P4M2915TwNKELke+KXiwNKldRYdG4ddtgVOkL0nfrXuTrXFi1dVLU7 8RUAUbotqXj8D96f1RqJO7hmVwURkRwtVAuE1nstFsLdQZPtUqQYsD86ixnu8F+qseIW qFdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:reply-to :mime-version:content-transfer-encoding; bh=IMI2wMwkjGBuhCKQPX7Bv66fQJz6nW5T373vF4VScoU=; b=aqVDd5QoOMQrPwYdtbExQmsZ7TENzEwMoPAf6qhWua8NG0dfpOebAMFFnrEYqMt0mo HSjB+t0S3QkP19TKTVSOb5RNcDSfKkjqwxBxyS6E3xXephum5YSYmRw8pwmqPil1Qn6+ /6VMMKkh0ur10N5nYmH4zmM1awFIkgP2pUHscp4ApWI2ILge3/gVG0l6cdddpjAehPEm eW/WPFcuRe/XoeAIyF0orhwXy+QVprCwQPnrk7buOJUdx6wyDSODW8b0t1pAnUdtioUn 3XJMU83jx7TCY4xu1H+RS7o8X2ILZsC+MWYpYa952vB+v2H+Q8H+ZzGyhgwCacG8zKjO GkvA== X-Gm-Message-State: AOAM532DvUt815OsZ3zsTfT76iDRTZ+/vPNkPPOv8OaWsyw4uCIjzlUN VacBKdEMrly79bt1XpM7/Rm4FbYJro4= X-Google-Smtp-Source: ABdhPJx28BbnNDEvVMkHXwUHV072zRk8xm1+0fBzmr1SZ6qDu3MRZBMSfKrdPwkyddYZOsf8LMyR/w== X-Received: by 2002:a17:907:7b9b:: with SMTP id ne27mr12248034ejc.318.1625657350095; Wed, 07 Jul 2021 04:29:10 -0700 (PDT) Received: from ernst.home (pd9e2360f.dip0.t-ipconnect.de. [217.226.54.15]) by smtp.gmail.com with ESMTPSA id t6sm8567778edd.3.2021.07.07.04.29.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jul 2021 04:29:09 -0700 (PDT) Date: Wed, 7 Jul 2021 13:29:08 +0200 From: Gary Jennejohn To: freebsd-current@freebsd.org Subject: kernel build fails due to incorrect call to ktls_disable_ifnet Message-ID: <20210707112908.289f9726@ernst.home> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4GKcdM2s8kz4hpj X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=H1Dk1XrA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of gljennjohn@gmail.com designates 2a00:1450:4864:20::635 as permitted sender) smtp.mailfrom=gljennjohn@gmail.com X-Spamd-Result: default: False [1.92 / 15.00]; HAS_REPLYTO(0.00)[gljennjohn@gmail.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; REPLYTO_ADDR_EQ_FROM(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RBL_DBL_DONT_QUERY_IPS(0.00)[2a00:1450:4864:20::635:from]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RECEIVED_SPAMHAUS_PBL(0.00)[217.226.54.15:received]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(1.00)[1.000]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_REPLYTO(0.00)[gmail.com]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; NEURAL_SPAM_MEDIUM(1.00)[1.000]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[2a00:1450:4864:20::635:from:127.0.2.255]; NEURAL_SPAM_LONG(0.92)[0.915]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::635:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-current] X-ThisMailContainsUnwantedMimeParts: N I don't remember seeing this reported. Recent HEAD kernel build results in this error: make[1]: "/usr/src/Makefile.inc1" line 337: SYSTEM_COMPILER: Determined that CC=cc matches the source tree. Not bootstrapping a cross-compiler. make[1]: "/usr/src/Makefile.inc1" line 342: SYSTEM_LINKER: Determined that LD=ld matches the source tree. Not bootstrapping a cross-linker. -------------------------------------------------------------- >>> Kernel build for ernst_new started on Wed Jul 7 12:53:52 CEST 2021 -------------------------------------------------------------- ===> ernst_new -------------------------------------------------------------- >>> stage 1: configuring the kernel -------------------------------------------------------------- Kernel build directory is /home/garyj/obj/usr/src/amd64.amd64/sys/ernst_new Don't forget to do ``make cleandepend && make depend'' -------------------------------------------------------------- >>> stage 2.3: build tools -------------------------------------------------------------- -------------------------------------------------------------- >>> stage 3.1: building everything -------------------------------------------------------------- linking kernel.full ld: error: undefined symbol: ktls_disable_ifnet >>> referenced by tcp_var.h:1161 (/usr/src/sys/netinet/tcp_var.h:1161) >>> tcp_output.o:(tcp_account_for_send) --- kernel.full --- *** [kernel.full] Error code 1 This is caused because ktls_disable_ifnet() is present in /sys/kern/uipc_ktls.c, which is included in the kernel build only when options kern_ktls is present in the config file. I do not have this option set. So, it's wrong to blindly call this function in tcp_var.h. Commenting out the relevant code results in a successful build. -- Gary Jennejohn