From nobody Wed Dec 22 18:37:25 2021 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E1DCD1907C28 for ; Wed, 22 Dec 2021 18:37:27 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JK29z5nfZz3sxy for ; Wed, 22 Dec 2021 18:37:27 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-wr1-x429.google.com with SMTP id r17so6705075wrc.3 for ; Wed, 22 Dec 2021 10:37:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=vU3TxG6THDHaGKvgBwjopuufF8HY2JRXwIouBcYoqyg=; b=Z18xkmT/evWksbZo6Ji9YlyWT0/r7dQryStlW0QwEkKtUUIWSF3cSruasNt0e5tWGj AiQ3PZa/auad6KuDEP6VE+dEljroErkPE+zAulPDv9oejHSZ4YTLcRB9MegLLlNT9L02 ojafJDZtKqvpAaILWcqbQxnJVek62U/bea8zgwTWRo4hnTQzABpPUtxfETMywkLlO2xx hRGxBUAwdzCIUrMHVn1P3MYzfZ/vlqW6bEyBiB7SdVqto2gTWsgH6xvzmu05ZwJJcDio 6EeeE66v7xn25CL9rSUdrcPRVdl5X2VjBpfxSTfeBll7jRVCEUXfDDFB9cO3yiqKkFte QLPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=vU3TxG6THDHaGKvgBwjopuufF8HY2JRXwIouBcYoqyg=; b=506QU2AvlH5Od5+gCzRW0WkV2iwVVMlH0AK2bB3FeqihPda2ZecU4px+1dzsst6ACO 6PVeT6TWKCVwx/OgT2yS0lk0j56Lj7Ta7mDvqFPJIeyfcZv2mii2zfKjhPkJdJy5u0Kx 3PgYUF+j5hQPoWj49h44VJ5rxnokvfdDx/RMUoRlhVYxMCdn7mDTYcn9HlRIFCq2Lvax hpKa+e6kXRQGO7lOd9ehc+TZuL3K3d0QrRsrPn/Nh8dmCIW6mGYlNnEO7I57VsQWDyGa brZuRomr0yx0R6z6ocYalU+/HK/pQRat61r4gvy+ZldIoKxcKYQlR9AIIx4w/W2c/RWj kHog== X-Gm-Message-State: AOAM530HFpVdnIoGGV4NrzjqnSX5d00RdyY7nEoEnJGhWFqSVg/kfwCE Cy+mJzhEatJt6zOsV4/mfnQR+kLU3pE= X-Google-Smtp-Source: ABdhPJz1MjhWI1gAuSegLTAZCR3yJPxKxJ3kx/54Z/sH1npfzgfRvazcDo/s64oobj7vBss7ZC46Ug== X-Received: by 2002:a05:6000:2a4:: with SMTP id l4mr3040289wry.460.1640198246919; Wed, 22 Dec 2021 10:37:26 -0800 (PST) Received: from ernst.home (p5b3be0d9.dip0.t-ipconnect.de. [91.59.224.217]) by smtp.gmail.com with ESMTPSA id u23sm2335560wmc.7.2021.12.22.10.37.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Dec 2021 10:37:26 -0800 (PST) Date: Wed, 22 Dec 2021 19:37:25 +0100 From: Gary Jennejohn To: Warner Losh Cc: FreeBSD Current Subject: Re: WITHOUT_PF breaks buildworld Message-ID: <20211222193725.19f2f03a@ernst.home> In-Reply-To: References: <20211219114723.338b235e@ernst.home> <61bf1204.1c69fb81.2c8fc.3280SMTPIN_ADDED_BROKEN@mx.google.com> <20211219122443.1c84093f@ernst.home> <74FC7625-295C-4DEC-BF35-434B5F8D7832@FreeBSD.org> <20211222165154.33ef54fd@ernst.home> <20211222170151.05a4afe3@ernst.home> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4JK29z5nfZz3sxy X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Wed, 22 Dec 2021 10:58:50 -0600 Warner Losh wrote: > On Wed, Dec 22, 2021, 10:02 AM Gary Jennejohn wrote: > > > > > This simple patch to /usr/src/include/Makefile fixes it for me: > > > > --- Makefile.orig 2021-12-22 13:37:02.817745000 +0100 > > +++ Makefile 2021-12-22 13:37:12.177336000 +0100 > > @@ -246,9 +246,7 @@ > > INCSGROUPS+= IPFILTER > > .endif > > > > -.if ${MK_PF} != "no" > > INCSGROUPS+= PF > > -.endif > > > > .if ${MK_CDDL} != "no" > > INCSGROUPS+= NVPAIR > > > > Since pf.h is used so widely in the tree it's probably the simplest fix. > > > > I like this. I'd unconditionally remove the test in preference to adding it > conditionally. > If I still had my commit bit I'd do it myself :-) -- Gary Jennejohn