From nobody Wed Dec 22 15:27:52 2021 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4116C1901ED6 for ; Wed, 22 Dec 2021 15:27:56 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JJxzH71xXz4ppp; Wed, 22 Dec 2021 15:27:55 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id B88C71A1F; Wed, 22 Dec 2021 15:27:55 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id C33DA41E73; Wed, 22 Dec 2021 16:27:53 +0100 (CET) From: Kristof Provost To: Konrad =?utf-8?b?U2V3acWCxYJvLUpvcGVr?= , Warner Losh Cc: gljennjohn@gmail.com, Alastair Hogge , freebsd-current@freebsd.org Subject: Re: WITHOUT_PF breaks buildworld Date: Wed, 22 Dec 2021 16:27:52 +0100 X-Mailer: MailMate (1.14r5852) Message-ID: <74FC7625-295C-4DEC-BF35-434B5F8D7832@FreeBSD.org> In-Reply-To: References: <20211219114723.338b235e@ernst.home> <61bf1204.1c69fb81.2c8fc.3280SMTPIN_ADDED_BROKEN@mx.google.com> <20211219122443.1c84093f@ernst.home> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1640186876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gbWb6NqjJhgaJDrGhaxhr2iMZ9SP/DHIaVDlMk08w5o=; b=RCcsq1Lg9tc1c7vrXEIVcD9ghHt1U7s5Zt5JdmlsVoRRqiwwTq5AaN0RgiYVAWKsMhF8Wy Mjfa92UtGLMRUwUZREQRBVylex1MdC0vqb2kN05H6AVVHouy8prtY0+FrGnh/7sLQeavev 45nrnehCsLs7AaSdvjHfSvzuV+KUjH640MefQfUg4UQ4JBWF0gDhOInF4kQnfclPDGyN9t 7u9CB9DquLPOxPtv0/Xd66ZvC8TGzuv41z/XKlU8UZy+LjTi6HmDU3rKlkgI+jr4Tlar/t ZUKjlucjzsr+DsAx/3MAwwvpA0aFkcDyL2T+mmJbq6FzzDRpoOtv6k0paADgCA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1640186876; a=rsa-sha256; cv=none; b=fFsJyDyJj4NwmdkzbAJTc+KMeg8fOBXSW1wxImHccUMDXdoDVUccaPKH2vMvCaqQLXWnpI SKpP2vPEv+KqYEd4s4V6VfDr8mIT/Ck+8Yzk9tmjVoRcnPBLSldpDXOmrIB1f3C3yWtcs3 GIWJnl2d2myeVlP5OapJdw+bKZyiFN6J8zqae4lhgWdGEIXKOL+8WgYbPVYS5w/0jRalXK BaQMUxgUaWQ8zSpfEpE4OXIXOKznP7eiX6tG/TTV+mTM0q8B8x+DcJRuPcW+1p4WTUiATI qNUfqDRlSenVgRXVHY3PuGVNcC30U1fYyQytrsgTN2y2MPomH7pt60Romjn28g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 22 Dec 2021, at 8:21, Konrad Sewi=C5=82=C5=82o-Jopek wrote: > Hi, > > I think the reason is somewhere in tools/build/test-includes: > > --- net/if_pfsync.o --- > In file included from net/if_pfsync.c:1: > In file included from > [...]freebsd/arm64.aarch64/tmp/usr/include/net/if_pfsync.h:56: > [...]freebsd/arm64.aarch64/tmp/usr/include/net/pfvar.h:65:10: fatal err= or: > 'netpfil/pf/pf.h' file not found > #include > ^~~~~~~~~~~~~~~~~ > 1 error generated. > *** [net/if_pfsync.o] Error code 1 > > make[3]: stopped in [...]freebsd/tools/build/test-includes > --- net/pfvar.o --- > In file included from net/pfvar.c:1: > [...]freebsd/arm64.aarch64/tmp/usr/include/net/pfvar.h:65:10: fatal err= or: > 'netpfil/pf/pf.h' file not found > #include > ^~~~~~~~~~~~~~~~~ > 1 error generated. > *** [net/pfvar.o] Error code 1 > > make[3]: stopped in [...]freebsd/tools/build/test-includes > 2 errors > > make[3]: stopped in [...]freebsd/tools/build/test-includes > *** [test-includes] Error code 2 > > make[2]: stopped in [...]freebsd > 1 error > > Best regards, > Konrad Sewi=C5=82=C5=82o-Jopek > > > niedz., 19 gru 2021 o 12:26 Gary Jennejohn > napisa=C5=82(a): > >> On Sun, 19 Dec 2021 19:05:35 +0800 >> Alastair Hogge wrote: >> >>> On Sunday, 19 December 2021 6:47:23 PM AWST Gary Jennejohn wrote: >>>> Some recent change, probably in a .mk file, breaks builworld on HEAD= >>>> when WITHOUT_PF is enabled in src.conf. >>> >>> I have had to disable WITHOUT_PF since 2020-07-27, but probably earli= er. >>> >> >> Hmm. I did a successful buildworld a few days ago with WITHOUT_PF >> enabled, so it's new breakge for me at least. >> >> I don't enable pf in the kernel and don't need it in userland. >> >>>> Disabling WITHOUT_PF results in a successful buildworld. >>>> >>>> The reported error is that netpfil/pf/pf.h can't be found. >>> >>> Some ports depend on that too. >>> >> This is the test-includes target, which validates that include files are = self-contained (that is, you can =E2=80=98#include <$file>=E2=80=99 witho= ut prerequisites. The target fails because it looks at all headers in /usr/src/sys and then= tries to build them, but some of those headers (like the pf headers) inc= lude other headers that may not be getting installed because they=E2=80=99= re disabled. I=E2=80=99m not quite sure how to best fix this. Note that it is not happening because some pf tools are still getting bui= lt. This is a validation target that fails. We could potentially add the pf headers to BADHDRS depending on the WITHO= UT_ flag, but that would mean manually maintaining badfiles.inc. Or perhaps we should keep installing the pf headers even when WITHOUT_PF = is set, but I=E2=80=99m not actually sure how we convince the build syste= m to do that. Or if it=E2=80=99s a good idea. Warner might have better ideas on how to fix this. Kristof