[Bug 279397] www/chromium sqlite3_shim.c compilation error

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 03 Jun 2024 13:35:29 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279397

--- Comment #19 from Florian Walpen <dev@submerge.ch> ---
(In reply to Robert Nagy from comment #15)
> I cannot reproduce this on 13.3/amd64 so I assume this happens due to some
> header poisoning from some dependencies.

I suppose you did check that all of your patches are in main now?
The trigger has to be somewhere in the changes since 125.0.6422.76, but I
didn't see anything obvious in port commits. Maybe a chromium upstream change?

BTW, we have patches in www/chromium specific to OpenBSD, are we sharing
patches with OpenBSD chromium maintainers? Does their port build?

> If that is to be upstreamed the comment needs to be fixed up as well.

Yeah, it's not meant to be upstreamed just like that, but I'd want to discuss
and test the (supposedly) proper fix here before proposing it upstream.
Regarding upstream, SQLite still has no pull requests anyway, but they got a
support forum since my last SQLite bug fix long time ago. There I found a
similar PR:

https://www.sqlite.org/forum/forumpost/6a755ae973123d61c7a22aeabbd16d1f2b5747e94fddd59207e56fa9d0b97e66

I think we could offer both the proper fix and one checking for __FreeBSD__
only. They may be hesitant to possibly break other build systems. Long standing
bugs tend to become standard ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.