[Bug 258271] www/chromium: Makefile warning for grep mempcpy /usr/include/string.h. This warning is redundant and persistent.

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 08 Sep 2021 12:58:45 +0000
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258271

--- Comment #10 from Tomoaki AOKI <junchoon_at_dec.sakura.ne.jp> ---
(In reply to Robert Clausecker from comment #8)
Why I'm hesitating to use regular OSVERSION way here is because no commit for
version bump mentions about mempcpy() addition.
This can make confusion tracking changes in the future.

Single bump for multiple commits is NOT AT ALL a problem, if the commit message
lists all targetted commits, regardless they're related each other or not.

If I'm not missing something, no bump mentions the commits adding mempcpy().

And for this case, checking for mempcpy() instead of checking for OSVERSION has
an advantage that no more update is needed when mempcpy() is added to branches
that doesn't have it currently.
www/chromium is a huge port and changes without actual update would be better
minimized, I think.

Anyway, Felix's latest patch looks fine enough for me.
Thanks again, Felix!

-- 
You are receiving this mail because:
You are the assignee for the bug.
Received on Wed Sep 08 2021 - 12:58:45 UTC

Original text of this message