[Bug 258271] www/chromium: Makefile warning for grep mempcpy /usr/include/string.h. This warning is redundant and persistent.

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 07 Sep 2021 13:39:33 +0000
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258271

Robert Clausecker <fuz_at_fuz.su> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fuz_at_fuz.su

--- Comment #8 from Robert Clausecker <fuz_at_fuz.su> ---
(In reply to Tomoaki AOKI from comment #5)

I'm not sure what you are missing.  We have checked when this change was done
in base and the first OSVERSION bump after this change was two days later and
is the one found in the patch.  So only if someone built an OS in the two days
between the commit and the OSVERSION bump the check would be wrong and then in
the harmless direction, i.e. not using mempcpy when it is available.

What's wrong with doing it that way?  It is sufficiently accurate, idiomatic
(see ยง4.4 porter's handbook), fixes the warning, and improves performance.

They're not going to bump OSVERSION for every single commit, so I'm not sure
what you are looking for.

-- 
You are receiving this mail because:
You are the assignee for the bug.
Received on Tue Sep 07 2021 - 13:39:33 UTC

Original text of this message