[Bug 258271] www/chromium: Makefile warning for grep mempcpy /usr/include/string.h. This warning is redundant and persistent.

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 06 Sep 2021 17:35:57 +0000
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258271

--- Comment #6 from Felix Palmen <felix_at_palmen-it.de> ---
(In reply to Tomoaki AOKI from comment #5)
> NEVER DO IT UNTIL CORRESPONDING BUMP ON BASE IS DONE, please!

> The problematic commit on base doesn't have corresponding bump.
> This kind of change SHALL make future confusion.
The only reason I could see *not* to resort to OSVERSION would be if the patch
would actually break something when strpcpy() is present in base. Even then, I
wonder whether it's worthwhile to have such an ugly hack in place just for a
period of 2 days when base had a commit without an OSVERSION bump… but then, it
won't be me to decide, I suggested two approaches for a reason.

> And the fix is already proposed on Bug257352 by Tatsuki Makino.
This fix over there has the drawback that the grep is still executed every time
the Makefile is evaluated (instead of only on expansion of EXTRA_PATCHES).
Unfortunately, I think there's no really readable solution to fix this, you'd
have to live with what I suggested above.

-- 
You are receiving this mail because:
You are the assignee for the bug.
Received on Mon Sep 06 2021 - 17:35:57 UTC

Original text of this message