[Bug 298192] sbin/bectl/bectl_jail.c: -Wformat-overflow issue reported by gcc14 in error path

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=298192

Benjamin Jacobs <freebsd@dev.thsi.be> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |freebsd@dev.thsi.be

--- Comment #4 from Benjamin Jacobs <freebsd@dev.thsi.be> ---
(In reply to Kyle Evans from comment #1)
It seems legit:

jailparams_delarg(arg) either returns EINVAL if arg==null or
jailparam_del(arg).
jailparam_del returns 0 no matter what.

So if jailparams_delarg() does not return 0, it means that arg==null.

The bug is likely that the jailparm_del function doesn't propagate the
nvlist_remove_all error upward. Or if that is really infallible, you can try
else if (ret != ENOENT && ret != EINVAL) but then the code will be unreachable
anyway so there might be a logic error somewhere :)

-- 
You are receiving this mail because:
You are the assignee for the bug.