[Bug 299244] virtio_console ignores RX flow control, drops data

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=299244

Faraz Vahedi <kfv@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kfv@FreeBSD.org

--- Comment #1 from Faraz Vahedi <kfv@FreeBSD.org> ---
Thanks a lot for the report and the patch, and for digging into it!

I was aware of this one and am planning to tackle it as part of
some work I'm doing on virtio_console(4) at the moment.  I'll
surely reuse parts of your patch, but it can't go in as is: the
tty layer already holds the port mutex when it calls
tsw_inwakeup, so taking it again there trips the non-recursive
mutex check on kernels with INVARIANTS, and the receive path is
changing in my series, so the fix needs to fit in with that.
That said, your effort is very much appreciated and you'll be
credited in the corresponding commit.

> I also have no idea how contributing patches to FreeBSD works

I assume you've seen the Contributing to FreeBSD article, but if
not, you can find it at
https://docs.freebsd.org/en/articles/contributing/.

You can send your patches here, on reviews.FreeBSD.org, or as
GitHub pull requests for smaller changes.  Do not hesitate to
contact us if you need further guidance or a hand to get started.

Again, thanks a lot for your help, David.

-- 
You are receiving this mail because:
You are the assignee for the bug.