[Bug 295637] mlx4ib: Fix EQ resource leak on mlx4_ib_add() error path

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 05 Oct 2026 19:10:46 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=295637

Luis Castellanos <ing.castellanosdz@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ing.castellanosdz@gmail.com

--- Comment #1 from Luis Castellanos <ing.castellanosdz@gmail.com> ---
Reviewed the patch and verified on FreeBSD 14.5-RELEASE
(releng/14.5-n274872-4099b5c82880). Patch applies cleanly (Hunk #1 succeeded at
2773).

Code review confirms the resource leak: in mlx4_ib_add(), the normal teardown
path calls mlx4_ib_free_eqs() at line 2856, but the err_map error path at line
2747 jumps directly to iounmap() without freeing EQs. The fix correctly adds
mlx4_ib_free_eqs() before iounmap in the error path, matching the cleanup order
of the normal teardown.

The patch is correct and minimal. Submitted to Phabricator as D60354.

-- 
You are receiving this mail because:
You are the assignee for the bug.