[Bug 296767] powerpc64le: panic in _vm_page_pqstate_commit_dequeue (page-queue TAILQ corruption) under heavy SMP load

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=296767

--- Comment #6 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=d809a10218884162ed47c658233746c53a98b1aa

commit d809a10218884162ed47c658233746c53a98b1aa
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2026-07-17 12:57:06 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2026-07-17 13:18:15 +0000

    vm_page: Fix dequeue on arches with weak ordering

    A vm_page's a.queue field records the page queue index for the page
    queue to which the page belongs.  The PGA_ENQUEUED flag indicates
    whether the page is actually enqueued in that queue's TAILQ.  When
    modifying the a.queue field, you need to hold the page queue lock for
    the queue corresponding to the old value, unless the old value is
    PQ_NONE.

    Suppose a managed page is freed.  vm_page_free_prep() calls
    vm_page_dequeue_deferred(), which checks whether the page belongs to a
    queue; if so it schedules an asynchronous dequeue operation so that page
    queue lock acquisitions can be batched if possible.

    The dequeue operation must be completed before the page's plinks.q
    fields are reused.  So, during page allocation, we call
    vm_page_dequeue() to finish the dequeue operation.  Similarly, since the
    buddy allocator uses the plinks.q fields for its own internal linkage,
    vm_freelist_add() calls vm_page_dequeue().

    _vm_page_pqstate_commit_dequeue() is the function which actually removes
    the page from its queue.  It sets a.queue = PG_NONE and removes the page
    from its queue.  However, the update to the page's atomic state is
    relaxed, so on systems with store reordering, it may race with a
    concurrent enqueue of the page into the buddy queues (probably more
    likely) or a page queue.

    Fix this: use a release store to update the page's queue state in
    _vm_page_pqstate_commit_dequeue(), and make sure that vm_page_dequeue()
    uses an acquire load when comparing m->a.queue == PQ_NONE.

    PR:             296767
    Reported and tested by: pkubaj
    Reviewed by:    alc, kib
    MFC after:      1 week
    Differential Revision:  https://reviews.freebsd.org/D58261

 sys/vm/vm_page.c | 26 ++++++++++++++++++++++++--
 sys/vm/vm_page.h | 32 ++++++++++++++++++++++++++++++++
 2 files changed, 56 insertions(+), 2 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.