[Bug 113912] tunefs(8): silent failure setting glabel on boot partition

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=113912

--- Comment #6 from Michael Osipov <michaelo@FreeBSD.org> ---
(In reply to rkoberman from comment #5)

From my naive search 'tunefs -L'  does not set a GPT label. tunefs.8 does not
say that and if I look into the source code I see fs->fs_volname populated:
$ grep -r fs_volname .
./sbin/dumpfs/dumpfs.c:         afs.fs_volname, (uintmax_t)afs.fs_swuid,
./sbin/dumpfs/dumpfs.c: if (fs->fs_volname[0] != '\0')
./sbin/dumpfs/dumpfs.c:         printf("-L %s ", fs->fs_volname);
./sbin/growfs/debug.c:      sb->fs_volname);
./sbin/newfs/mkfs.c:            strlcpy(sblock.fs_volname, volumelabel,
MAXVOLLEN);
./sbin/tunefs/tunefs.c:         strncpy(sblock.fs_volname, Lvalue, MAXVOLLEN);
./sbin/tunefs/tunefs.c:         sblock.fs_volname);
./share/man/man5/fs.5:  u_char   fs_volname[MAXVOLLEN]; /* volume name */
./sys/geom/label/g_label_ufs.c:         if (fs->fs_volname[0] != '\0')
./sys/geom/label/g_label_ufs.c:                 strlcpy(label, fs->fs_volname,
size);
./sys/ufs/ffs/fs.h: * The volume name for this filesystem is maintained in
fs_volname.
./sys/ufs/ffs/fs.h:     uint8_t  fs_volname[MAXVOLLEN]; /* volume name */
./tools/tools/find-sb/mini_ufs.h:        u_char   fs_volname[MAXVOLLEN]; /*
volume name */
./usr.sbin/fstyp/ufs.c:         strlcpy(label, fs->fs_volname, labelsize);
./usr.sbin/makefs/ffs/mkfs.c:   strlcpy((char *)sblock.fs_volname,
ffs_opts->label,
./usr.sbin/makefs/ffs/mkfs.c:       sizeof(sblock.fs_volname));

I would wonder how the FS on top of GPT knows that it sits on top of GPT.

-- 
You are receiving this mail because:
You are the assignee for the bug.