[Bug 289812] [vt] Make frsig field optional in VT_SETMODE.
- In reply to: bugzilla-noreply_a_freebsd.org: "[Bug 289812] [vt] Make frsig field optional in VT_SETMODE."
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 30 Sep 2025 18:59:00 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289812
--- Comment #4 from Ed Maste <emaste@freebsd.org> ---
Interestingly, in lib/libvgl/main.c: smode.frsig = SIGINT;
In any case I concur that frsig is currently unused and is unlikely to ever be
used, so requiring userland to set it doesn't make much sense.
I don't like having possibly-uninitialized values passed in though; what about
frsig == 0 as a special case, e.g.:
if (!(ISSIGVALID(mode->relsig) &&
ISSIGVALID(mode->acqsig) &&
(mode->frsig == 0 || ISSIGVALID(mode->frsig)))) {
DPRINTF(5, "error EINVAL\n");
return (EINVAL);
}
--
You are receiving this mail because:
You are the assignee for the bug.