[Bug 288898] VT: console fails to reply to primary device attribute query

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=288898

Kyle Evans <kevans@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kevans@freebsd.org

--- Comment #1 from Kyle Evans <kevans@freebsd.org> ---
teken_subr_primary_device_attributes is used in the state machine generated
from sys/teken/sequences -> teken_state.h in the kernel build directory.  The
problem, for vt(4), is the tf_respond implementation in
sys/kern/subr_terminal.c:

```
static void                                                                     
termteken_respond(void *softc, const void *buf, size_t len)                     
{                                                                               
#if 0                                                                           
        struct terminal *tm = softc;                                            
        struct tty *tp;                                                         

        /*                                                                      
         * Only inject a response into the TTY if the data actually             
         * originated from the TTY.                                             
         *                                                                      
         * XXX: This cannot be done right now.  The TTY could pick up           
         * other locks.  It could also in theory cause loops, when the          
         * TTY performs echoing of a command that generates even more           
         * input.                                                               
         */                                                                     
        tp = tm->tm_tty;                                                        
        if (tp == NULL)                                                         
                return;                                                         

        ttydisc_rint_simple(tp, buf, len);                                      
        ttydisc_rint_done(tp);                                                  
#endif                                                                          
}
```

I suspect we get through the state machine just fine, but our response is a
complete nop.

-- 
You are receiving this mail because:
You are the assignee for the bug.