[Bug 289480] WITH_VERIEXEC build option stops at cleandir_subdir_sbin/veriexec

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289480

Ed Maste <emaste@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|Works As Intended           |---
             Status|Closed                      |Open
                 CC|                            |emaste@freebsd.org

--- Comment #2 from Ed Maste <emaste@freebsd.org> ---
> Depends on WITH_BEARSSL which is documented, but not validated at build time.
> So, as expected?

As expected perhaps, but the failure should be explicit. "Invalid LIBADD used
which may need to be added to src.libnames.mk" is quite misleading.

share/mk/src.opts.mk handles a number of dependencies with things like:

.if ${MK_LOADER_VERIEXEC} == "no"
MK_LOADER_VERIEXEC_PASS_MANIFEST := no
.endif

The problem you encountered could be handled in a similar way with:

.if ${MK_BEARSSL} == "no"
MK_LOADER_VERIEXEC:=    no
MK_VERIEXEC:=           no
.endif

but I don't like this much, because the effect is that VERIEXEC just gets
forced off and what you specified on the commandline is just ignored. I'd like
something along the lines of:

.if ${MK_BEARSSL} == "no" && \
    (${MK_LOADER_VERIEXEC} == "yes" || ${MK_VERIEXEC} == "yes")
.error VERIEXEC requires BEARSSL
.endif

but done in a more generic way.

-- 
You are receiving this mail because:
You are the assignee for the bug.