[Bug 263229] virtio vtnet driver with rxcsum errors
- In reply to: bugzilla-noreply_a_freebsd.org: "[Bug 263229] virtio vtnet driver with rxcsum errors"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 10 Sep 2025 15:49:12 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263229
--- Comment #24 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:
URL:
https://cgit.FreeBSD.org/src/commit/?id=187ee62c71f2be62870f26ae98de865e330121be
commit 187ee62c71f2be62870f26ae98de865e330121be
Author: Michael Tuexen <tuexen@FreeBSD.org>
AuthorDate: 2025-09-10 15:13:35 +0000
Commit: Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2025-09-10 15:19:23 +0000
dhclient: improve UDP checksum handling
When sending UDP packets:
* compute the checksum in the correct order. This only has an impact
if the length of the payload is odd.
* don't send packet with a checksum of zero, use 0xffff instead as
required.
When receiving UDP packets:
* don't do any computations when the checksum is zero.
* compute the checksum in the correct order. This only has an impact
if the length of the payload is odd.
* when computing the checksum, store the pseudo header checksum
* if the checksum is computed as zero, use 0xffff instead.
* also accept packets, when the checksum in the packet is the pseudo
header checksum.
The last point fixes a problem when the DHCP client runs in a VM,
the DHCP server runs on the host serving the VM and the network
interface supports transmit checksum offloading. Since dhclient
doesn't use UDP sockets but bpf devices to read the packets, the
checksum will be incorrect and only contain the checksum of the
pseudo header.
PR: 263229
Reviewed by: markj, Timo Völker
Tested by: danilo
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D52394
sbin/dhclient/packet.c | 53 +++++++++++++++++++++++++++++++++-----------------
1 file changed, 35 insertions(+), 18 deletions(-)
--
You are receiving this mail because:
You are the assignee for the bug.