[Bug 286321] [FBSD 15.0 Current] kernel panic "panic: incoming crp already done" while running kyua tests with qat driver

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 09 May 2025 00:35:06 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=286321

--- Comment #2 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=2fa185f9bf5948ead9c3920d452ddd6bcad8f569

commit 2fa185f9bf5948ead9c3920d452ddd6bcad8f569
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2025-05-09 00:23:40 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2025-05-09 00:29:23 +0000

    crypto: Remove uses of CRYPTO_F_DONE

    Previously OCF set CRYPTO_F_DONE prior to invoking the completion
    callback, even if the request failed. This isn't particularly useful
    and leads to bugs when consumers retry a failed request, since OCF also
    asserts that CRYPTO_F_DONE is clear in crypto_dispatch(). (Really, OCF
    should retry requests that fail with EAGAIN, but that's a larger
    change.)

    For now, just stop setting CRYPTO_F_DONE to simplify consumers (and fix
    those which fail to clear the flag before retrying a request).

    PR:             286321
    Reviewed by:    jhb
    Differential Revision:  https://reviews.freebsd.org/D50104

 share/man/man9/crypto_request.9                       | 13 +------------
 sys/contrib/openzfs/module/os/freebsd/zfs/crypto_os.c |  1 -
 sys/kgssapi/krb5/kcrypto_aes.c                        |  1 -
 sys/opencrypto/crypto.c                               |  6 ------
 sys/opencrypto/cryptodev.c                            |  2 --
 sys/opencrypto/cryptodev.h                            |  2 +-
 sys/opencrypto/ktls_ocf.c                             |  2 --
 sys/sys/param.h                                       |  2 +-
 8 files changed, 3 insertions(+), 26 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.