[Bug 266987] bsdinstall: following multiple 'restart's, distributions are installed several times

From: <bugzilla-noreply_at_freebsd.org>
Date: Sun, 01 Jun 2025 13:07:33 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266987

--- Comment #7 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=9de72af2cceb6fc4aead0990cccdf565531bc248

commit 9de72af2cceb6fc4aead0990cccdf565531bc248
Author:     Pierre Pronchery <khorben@FreeBSD.org>
AuthorDate: 2025-05-23 15:50:42 +0000
Commit:     Pierre Pronchery <khorben@FreeBSD.org>
CommitDate: 2025-06-01 12:53:16 +0000

    bsdinstall: restore the environment when restarting

    It is possible to restart the installation process upon errors, when
    installing normally through the `auto` script, or when installing a jail
    with the `jail` script. However, some values obtained interactively from
    the user or guessed by some scripts were kept in the environment when
    restarting the process; this made it impossible to re-run some steps as
    expected after the restart.

    For instance, if a bad choice of mirror was made in the `mirrorselect`
    phase, restarting the installer remembered the choice made, and would
    never prompt for a different one again. Rebooting was then the only easy
    way out of this situation.

    This change restores a pre-defined list of environment variables when
    restarting the installation process.

    PR:             266987
    Reviewed by:    emaste
    Approved by:    philip (mentor)
    Sponsored by:   The FreeBSD Foundation
    Differential revision:  https://reviews.freebsd.org/D42281

 usr.sbin/bsdinstall/scripts/auto | 33 ++++++++++++++++++++++++++
 usr.sbin/bsdinstall/scripts/jail | 50 ++++++++++++++++++++++++++++++++++++----
 2 files changed, 79 insertions(+), 4 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.