[Bug 191135] [hptrr] probe hptrr INQUIRY CDB: 12 00 00 00 24 00 CAM status: Invalid Target ID Error 22
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 05 Feb 2025 01:38:38 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191135
--- Comment #4 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:
URL:
https://cgit.FreeBSD.org/src/commit/?id=f52154a2044a4d1f324952af05542f93fdf0a088
commit f52154a2044a4d1f324952af05542f93fdf0a088
Author: Warner Losh <imp@FreeBSD.org>
AuthorDate: 2025-02-05 01:31:25 +0000
Commit: Warner Losh <imp@FreeBSD.org>
CommitDate: 2025-02-05 01:38:02 +0000
hptrr: Better error recovery
This bug and
https://www.mail-archive.com/freebsd-stable@freebsd.org/msg124458.html
both have this fix. It turns unknown errors into an autosense failure,
which causes
us to grab the sense buffer manually. It also sets a condition that we use
to retry
timed out commands that jmg reports as being helpful.
I'm torn on committing it. The code seems fine in terms of fixing
things. But this is a 10-year-old bug with few other bugs and a short CC
list for a driver that might go away in 15 anyway. I'm going to commit
and close the bug, and MFC it in a week, unless someone complains (which
seems unliekly, given the age of this hardware, I susepct most of it is
out of service).
Suggested by: jmg, Scott Long
PR: 191135
MFC After: 1 week
Reviewed by: imp
sys/dev/hptrr/hptrr_osm_bsd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
You are receiving this mail because:
You are the assignee for the bug.