[Bug 291273] p9fs module missing symbol exports -- dependent modules fail to load with module loader local symbol resolution disabled

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291273

Rupesh Pilania <rupeshpilania@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rupeshpilania@gmail.com

--- Comment #2 from Rupesh Pilania <rupeshpilania@gmail.com> ---
I’ve tested the fixes by disabling symbol-leak suppression
(debug.link_elf_leak_locals=0 and debug.link_elf_obj_leak_locals=0) to ensure
unresolved symbols become visible. With the updated EXPORT_SYMS entries added
to sys/modules/p9fs/Makefile, both modules now load successfully without any
undefined symbol errors.

Patch Used:
diff --git a/sys/modules/p9fs/Makefile b/sys/modules/p9fs/Makefile
index ae90cb3a46d7..08a5b3ec0fa2 100644
--- a/sys/modules/p9fs/Makefile
+++ b/sys/modules/p9fs/Makefile
@@ -5,4 +5,10 @@ SRCS=  vnode_if.h \
        p9_client.c p9_protocol.c p9_transport.c \
        p9fs_subr.c p9fs_vfsops.c p9fs_vnops.c

+ EXPORT_SYMS=  \
+        p9_debug_level \
+        p9_destroy_zones \
+        p9_init_zones \
+        p9_register_trans
+
 .include <bsd.kmod.mk>

Test Logs:

root@freebsd16:~ # cat /boot/loader.conf
debug.link_elf_leak_locals=0
debug.link_elf_obj_leak_locals=0
root@freebsd16:~ # sysctl debug.link_elf_leak_locals
debug.link_elf_leak_locals: 0
root@freebsd16:~ # sysctl debug.link_elf_obj_leak_locals
debug.link_elf_obj_leak_locals: 0
root@freebsd16:~ # kldstat
Id Refs Address                Size Name
 1    8 0xffffffff80200000  2126750 kernel
 2    1 0xffffffff82d10000     3220 intpm.ko
 3    1 0xffffffff82d14000     2178 smbus.ko
 4    1 0xffffffff82d17000     2a80 mac_ntpd.ko
root@freebsd16:~ # kldload /boot/kernel/virtio_p9fs.ko
root@freebsd16:~ # kldstat
Id Refs Address                Size Name
 1   14 0xffffffff80200000  2126750 kernel
 2    1 0xffffffff82d10000     3220 intpm.ko
 3    1 0xffffffff82d14000     2178 smbus.ko
 4    1 0xffffffff82d17000     2a80 mac_ntpd.ko
 5    1 0xffffffff82d1a000     24e0 virtio_p9fs.ko
 6    1 0xffffffff82d1d000     a888 p9fs.ko

Both virtio_p9fs.ko and p9fs.ko now load without reporting undefined symbols.

-- 
You are receiving this mail because:
You are the assignee for the bug.