From nobody Wed Apr 30 20:46:31 2025 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Znq3W4nqRz5tyKN for ; Wed, 30 Apr 2025 20:46:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Znq3W2Y75z3c7Y for ; Wed, 30 Apr 2025 20:46:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746045991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b+z5g6KlRNGa0x67lxlVKbtiVVk0VGQOEV3JbmlE6fI=; b=yeGBhfTK25wkDLqLbN58WdNT1WFcvMSG3Bi63nTpqNUVmUxXuX6lttsYPjjM2e5pAKi6xy Ava0oYY9JpDaYZxkDBtRIFXK2zSWzwZYLTepKhmFlbQIEnj893sb/78xg7gjCeIGNc4rS3 P8COesNxCQ15MNk52xEOUAx2GH7E0fgmVHHR047cOWHxHWfz7WdozbIOgNw8YXgq8nv0X8 B6VchJtIDugIvWt8B74MwapBliMjywr5e5q5kTUAmT+vm6iq2eB7tgnQ+Bo/vUgJ2XcYhb MTg+B6W7Y67cdAl+E8ukqr+MPAAnUWrrdGkU/wsnMEMa+TnUEqNrrqqT1oq08g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746045991; a=rsa-sha256; cv=none; b=ctm6ZrUnvra+/IeQPu7lA9CRYXI8RVqwoZy0NlAoAWeWTm4TYMGWprcs8XvIkGRoi12y3M wM6GIQktu82ya+aEUFhCM6mFdBk/FVJu7xkRJUL/d8bBr4W56XeGZs3lzsw2fTjKKgqx/C usSqzC3mUq6XUlBYjy7h1hDRTfidoDJeqowCR0IMx13Asen9sR5OWUncJM/pKgFW8C35C3 SQgUHfa0V0t86BXxCC9HHS/IW1UfD+bWhZk6GQ67OdeU5ed1GeHHb/HYLOvJV119TKhGBL okMtHcJWLga8xz0Q4C7gddC2TAnvWQtFGQNWZjihfEh92O1sAF24HNdR4qIxxQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746045991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b+z5g6KlRNGa0x67lxlVKbtiVVk0VGQOEV3JbmlE6fI=; b=Sab929spSoXY85jGDIYRM55b9h1agrVNBXs59XtvyND7leC0AuvoMInFtjK8tmRzjBA4Yi 0FL3OvNXSDJuggTONh53+17jJVewT0xj8t7/vW0pOYhQqHuAzrkq7TGyWrqkTBfOvFItpb TB3YDi0sj0waT+sry0D7UqDYGL6pH5/dnnTK12GXhLEnyzE0lDy4U5ZZx+r6gydanuCBpl dEShEcZPA8gT6Ddd2ase2wJe8nkOp6/yuOuue3D/x6dgOLnCJBTRCX5vb5lTV3IQDTy7Xr Q+MysPBLY2bXCRZA9hlmN0cQI3shLA0LnR+KZRo5hUcYWJi5Y2HLbgDOxK0AQQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Znq3W1gYVz67w for ; Wed, 30 Apr 2025 20:46:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 53UKkVkR086388 for ; Wed, 30 Apr 2025 20:46:31 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 53UKkVwg086386 for bugs@FreeBSD.org; Wed, 30 Apr 2025 20:46:31 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 283355] install: -U does not validate -o and -g values Date: Wed, 30 Apr 2025 20:46:31 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: pat@patmaddox.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D283355 --- Comment #2 from Pat Maddox --- I agree that these should not be validated. This PR is in response to this comment: https://github.com/freebsd/freebsd-src/pull/1550#issuecomment-2543992885 As mentioned in my reply (https://github.com/freebsd/freebsd-src/pull/1550#issuecomment-2543997101) I think it's reasonable to set uid / gid values that may not be on the builder machine, but will be present on the installed machine. Plus there's the reality that chown / chgrp let you set any ID, even if it doesn't correspond to a user in /etc/passwd. Thus I don't see any reason why install should validate uid / gid semantica= lly (i.e. known on the present machine). Ensuring that they are within acceptab= le ranges seems reasonable to me. Jessica Clarke has expressed a clear preference for validating (it was a few months ago, things may have changed since). I'm not sure how a conversation like this proceeds. --=20 You are receiving this mail because: You are the assignee for the bug.=