From nobody Fri Apr 18 18:40:24 2025 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZfNqY0WTLz5tBkm for ; Fri, 18 Apr 2025 18:40:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZfNqX3mWXz3QHh for ; Fri, 18 Apr 2025 18:40:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745001624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a/8rhXiuQQDVcqZNeU6yHYslgf28urfAJgpBYgeD178=; b=h1a1tkrt5uF3J4ouSrmGRIUXxagDGl2g2IXOXpC0ual3xddNTzQyQwrtuRrNczkAhcPi3D kXbYJclMz4GMp/pKLMlzO+Rf7sonS73kBOjEjDdhZXW4IC0NA1RuwwBagp6VE6At91lJIh Uiy1ssv9X9nN/ZM5Hwzy6GYbt8PQjD6Ps7jF46qqCe/xOyLNDO184ZceJFDDjWmJuXw0hI I/oTQhSeCpyJJe/iaPXXK98aS9ybNAGxd8Y/C+y3JpdA/Ei7FS4W8nRECnk++N6ffhr4dU 4HBboJQV+jDCG9Nkpwke0Ah4BikK4zq9KXI84aT/QpW+ffgIot7vNAUeIuJceg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1745001624; a=rsa-sha256; cv=none; b=nkzRj77flvQa99dpGjeBDjwrxI7Yii6MjsFGj8I7MXiEaZpr7phFNmB6nLth2lxvnnzGOx H0oJHd4KYiws68fcmz2Fy5XpuNZWxCAAJYGJGarORKS1iNKrIyP26WwTtkunKMOh8fOc+f xI26mTKFY/9ObfJ3oi/+m7DWctFN8mSh2iDNmHaLkNGxu32g10qkzUvWl5xZLl3brejeqh zDlEMeqxvdKQWtasY/0D+C9zC58W/7SliI/TD40DdLZUGcTckPPbbYuKQXoi59Mh1nAORs 8jKmIaAyXn514l2FqrD93tAAT0jbECWGnLglSyv+MjNp7Qb0srzyxG81Zig16A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745001624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a/8rhXiuQQDVcqZNeU6yHYslgf28urfAJgpBYgeD178=; b=BwxiKbqJjzwRiGsTnONgQErAlR9F5n2hNnYZOWvPX3Y7Q8GFT+03Xm3g2E8WgrjXj8uJ67 5wdGI+EBpGB4ihWIm1tGWfM5sQibtzlgdnlfFQqxKBlGLQUKsJMCFJroX3ca5SmtxYZFSM 3NIbjxmn3WseiJhw0g2b3PYh3zYX+zHsGpoYarN/l463ZA7U88wGlFJnuq65n7cmFpDFWM oPAk7zSHgIvTczBku8hNG8AIHz0XoL5Vz4ypBKSkb1tz3ycvCPdUzHI9h39WJhFtj0tw6v jylp4gPz3lSQmdUYybwbbV9rf4l0pWuaCMu5+LefZwuDk0aUGATASm4YuMIsCw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZfNqX2yhpzm1x for ; Fri, 18 Apr 2025 18:40:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 53IIeOQ4094431 for ; Fri, 18 Apr 2025 18:40:24 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 53IIeOl7094430 for bugs@FreeBSD.org; Fri, 18 Apr 2025 18:40:24 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 285993] nvme device breakage in 14.2 STABLE n270867-25df691800f0 Date: Fri, 18 Apr 2025 18:40:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.2-STABLE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jhb@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? mfc-stable14? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D285993 --- Comment #22 from John Baldwin --- Hmm, so two things stand out to me: 1) We were able to clear the PFD bit (0x02): pcib10: initial SLOT_STA 0x15a pcib10: cleared SLOT_STA 0x40 yet the device set it again later: pcib10: Power Fault Detected pcib10: (3) PCIEM_SLOT_STA_PFD pcib10: (3) PCIEM_SLOT_STA_PFD pcib10: card not inserted It was also set for pcib11 initially: pcib11: initial SLOT_STA 0x12 pcib11: cleared SLOT_STA 0 2) The slot capabilities register (the one read at offset 0xa4) does not include support for a power controller: #define PCIEM_SLOT_CAP_PCP 0x00000002 is not set in 0x02d80078. Without a power controller present, there shouldn't be power fault events b= y my reading of the PCI-e spec. That suggests that this might fix your system: diff --git a/sys/dev/pci/pci_pci.c b/sys/dev/pci/pci_pci.c index 5e71a376604b..10de719e020d 100644 --- a/sys/dev/pci/pci_pci.c +++ b/sys/dev/pci/pci_pci.c @@ -930,7 +930,8 @@ pcib_hotplug_inserted(struct pcib_softc *sc) return (false); /* A power fault implicitly turns off power to the slot. */ - if (sc->pcie_slot_sta & PCIEM_SLOT_STA_PFD) + if (sc->pcie_slot_cap & PCIEM_SLOT_CAP_PCP && + sc->pcie_slot_sta & PCIEM_SLOT_STA_PFD) return (false); /* If the MRL is disengaged, the slot is powered off. */ --=20 You are receiving this mail because: You are the assignee for the bug.=