From nobody Thu Apr 10 14:58:12 2025 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZYNGs4zlfz5t33T for ; Thu, 10 Apr 2025 14:58:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZYNGs2s1Zz3HS0 for ; Thu, 10 Apr 2025 14:58:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744297093; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hjWxtar5s97Kv7wPPpDwMPxd//rxSdFhkWw0qukEsPg=; b=GbxInyhnhTr3o5SAeUI+9KVM4pxPSe/tpTuEnSgLG4HD2gOgqCyr2+0Eng7hK9f9GT36To wNRc3X46VviDnOPtny+o9Pzcf9MMvl+a/tfeyLNXdQ3/u26kv6JYV3Eqy+22ZQYfGym3Uz wJU0CRS/h+B4K6vHuFhIS3eDVy/IBpg/nGs2L5elZvpNcgbL1DrPBfGHJmUIZxG3ddXYfw 4/w+rhFaVsip7ZFlhkVUVjLs0Z7k0i9M4/brkI4EBP/8B/BCameHnnL/zi85gbSWmp8p8j sPX+riJOutjLZG7vxh+IP9WtVRXJlAcwFQ5te5082gz2FzeqjPcob2BTmgJZpQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1744297093; a=rsa-sha256; cv=none; b=U+u3jReTw5IrwN2EU+r3iq46SPJafHTXrcU51asuYiMaT/lGjwkPg09YwUmp7y/mTQZLcJ OaKHXraNl5hypqOkMkW7Lb7IVrY1O12Jx4zsCtjWsuMvyYOKILae1SBI5599Kbw+Xfibsm wBHW6LYL2wQRb78JQdqGyJcmwhpQbyisnMFDB0xsyLsSdCgbpURLR+2S8j6iN6lJuV31ow CTTlHrpy+M3Vp+32bg7QNf1NGKIQFqb3WEbKR/CavMuJZ0fIyKedrHEsxtl/YDQgLmnqNH XJk49ZPJW8+0QB9rDcmf901TDo1BKtC35hmU0dpxGurtvNH5ZtXeZAzqEnmXyg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744297093; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hjWxtar5s97Kv7wPPpDwMPxd//rxSdFhkWw0qukEsPg=; b=qicQj46cEk5AlFiopu/B1e30e22eXmkSm3YUj/W/5Uv8lxN4TmqmLePpz4/ugqkBrtlV32 +XFUlHiR0Oh/j9U5EKssSUpCZUkrqTJKDJHvYHYCeDfA5n1wELeKCW9ZOOvkLKpnMPQnWg p0T5fqHnXtyM2L2dVCS+/dkps+Kq4OqdKDrq78mTEDKTrUL4tAIPJJZlkpRT2NC+2dWIp+ srcIY38BeSXF6WwmaCzlkTB4UaUWT4SZI3vJ7JVAQ2i6y2ah7fcgVIGlvAh72crU7LZGLz sQvasJmnSkk/qIbtRJwn8ieFMc8Ziq5o1FDPaCBS/Q/W8lve4ODLa/PuwPdtog== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZYNGs0qYzz171S for ; Thu, 10 Apr 2025 14:58:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 53AEwDnI072431 for ; Thu, 10 Apr 2025 14:58:13 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 53AEwDlB072430 for bugs@FreeBSD.org; Thu, 10 Apr 2025 14:58:13 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 277959] Refactor of usr.sbin/daemon caused regression in restart parameter Date: Thu, 10 Apr 2025 14:58:12 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.3-STABLE X-Bugzilla-Keywords: regression, vendor X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: secteam@FreeBSD.org X-Bugzilla-Flags: mfc-stable14+ needs_errata? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277959 --- Comment #37 from commit-hook@FreeBSD.org --- A commit in branch releng/14.2 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D4651d400f1000834365a21c59d6803da4= 474c63e commit 4651d400f1000834365a21c59d6803da4474c63e Author: Kyle Evans AuthorDate: 2024-11-19 19:51:27 +0000 Commit: Philip Paeps CommitDate: 2025-04-10 14:38:58 +0000 daemon: stop rebuilding the kqueue every restart of the child We populate the kqueue with all of four kevents: three signal handlers = and one for read of the child pipe. Every time we start the child, we rebu= ild this kqueue from scratch for the child and tear it down before we exit = and check if we need to restart the child. As a consequence, we effectively drop any of the signals we're interested in between restarts. Push the kqueue out into the daemon state to avoid losing any signal ev= ents in the process, and reimplement the restart timer in terms of kqueue timers. The pipe read event will be automatically deleted upon last close, which leaves us with only the signal events that really get retained between restarts of the child. Approved by: so Security: FreeBSD-EN-25:06.daemon PR: 277959 Reviewed by: des, markj (cherry picked from commit bc1dfc316a2bba97773a14b96f5e976a52524be4) (cherry picked from commit 7ea2874eadf901b1187772670169b6fc3a44d917) usr.sbin/daemon/daemon.c | 121 +++++++++++++++++++++++++++++++++++++++----= ---- 1 file changed, 101 insertions(+), 20 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=