From nobody Sat Mar 23 18:24:13 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V26zK70Chz5FbJ9 for ; Sat, 23 Mar 2024 18:24:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V26zK5mgvz44Tc for ; Sat, 23 Mar 2024 18:24:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711218253; a=rsa-sha256; cv=none; b=UhqW8xnBkKyQgbyE953AjPQ/BNGoYf5eSVSANOazXwHKHRj6KJXRv/S5T9YXd7eZlmH5U/ ZX1CeDXncUiyE3CWBoaceFAtPQ4Rx5BtvcnCkqhhMbw51sRvNYb2OqAWmXNwfjC37BpcIy Qaw8ezGkZ6pE967EPtPSm1Mh48C9GQY7J8sz366SGN8cVzegyvWrK6vQ2rxgbTkLxClJTm qYhxV0b5ie88WKpDLaAlnKILDOQ4/36uT0lg22MHh+3iduYsYCMm52fsQg6war6uz9Ak8c j4ju3PkIE99Cs2VieTkJd1dnQ0CCoygLhVlJpU/hhdxkwBO9XBbjtHHR1BTVyQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711218253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u4cRGY2wdABQc8Qxvx/KkVOvQO49gu0aU8iPL39G8nk=; b=czU3x33VxsUlYckwDxf3xSfUdMTn+fp/FEI3aoJI+kXuAuz8A/j96YtcfIWxD7bqG9osLF L2gy99/+1iF0L4szULAP39pFBImfZ3VQ/s0pAG5tRRt6tH/B7cEjVvgqRv3Gjp/8OBMXco uUOXNYYrnRN9hf86/ffh3HoQuypyjjCspz1QPvO/7LMPiibA790tHuAGrUCjQLWqvsPzx4 uyymmWAJLnMkpFaUZHInqAEVwC3/HUeBjXsazhTf7f4N9iFV7cCSi12rYOzgnulUa4kLEF WCltSPk4ZZ/nXRHd4n3QJywvgEJFfvlmv533Gz7fINYvNz1xOwUYsbRJc2DTsQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4V26zK5Mqvz10NH for ; Sat, 23 Mar 2024 18:24:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 42NIOD8g021870 for ; Sat, 23 Mar 2024 18:24:13 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 42NIOD5w021869 for bugs@FreeBSD.org; Sat, 23 Mar 2024 18:24:13 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 277908] zfs: cannot lookup extended attributes in capability mode Date: Sat, 23 Mar 2024 18:24:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: asomers@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277908 --- Comment #3 from Alan Somers --- This patch fixes the problem for me. A similar patch is probably necessary= to set extended attributes. However, as security-sensitive code, we need to g= et this reviewed carefully. diff --git a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c index 7f4f8e2e2f78..a4bfb75ff647 100644 --- a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c +++ b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c @@ -5362,7 +5362,7 @@ zfs_getextattr_dir(struct vop_getextattr_args *ap, co= nst char *attrname) #else NDINIT_ATVP(&nd, LOOKUP, NOFOLLOW, UIO_SYSSPACE, attrname, xvp); #endif - error =3D vn_open_cred(&nd, &flags, 0, VN_OPEN_INVFS, ap->a_cred, N= ULL); + error =3D vn_open_cred(&nd, &flags, 0, VN_OPEN_INVFS | VN_OPEN_NOCAPCHECK, ap->a_cred, NULL); if (error !=3D 0) return (SET_ERROR(error)); vp =3D nd.ni_vp; --=20 You are receiving this mail because: You are the assignee for the bug.=