[Bug 276119] mail: typing ^C twice during compose causes SIGBUS
- In reply to: bugzilla-noreply_a_freebsd.org: "[Bug 276119] mail: typing ^C twice during compose causes SIGBUS"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 05 Jan 2024 02:42:01 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276119
--- Comment #1 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:
URL:
https://cgit.FreeBSD.org/src/commit/?id=6c951b37170f1fb2ae8b4827070743e61b6eaed2
commit 6c951b37170f1fb2ae8b4827070743e61b6eaed2
Author: Lexi Winter <lexi@le-Fay.ORG>
AuthorDate: 2024-01-04 22:34:58 +0000
Commit: Mark Johnston <markj@FreeBSD.org>
CommitDate: 2024-01-05 02:40:53 +0000
mail: add volatile in grabh()
setjmp() requires that any stack variables modified between the setjmp
call and the longjmp() must be volatile. This means that 'saveint' in
grabh() must be volatile, since it's modified after the setjmp().
Otherwise, the signal handler is not properly restored, resulting in a
crash (SIGBUS) if ^C is typed twice while composing.
PR: 276119
Reported by: Christopher Davidson <christopher.davidson@gmail.com>
MFC after: 2 weeks
Pull Request: https://github.com/freebsd/freebsd-src/pull/993
usr.bin/mail/tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
You are receiving this mail because:
You are the assignee for the bug.