[Bug 276839] pkg upgrade with DEFAULT_ALWAYS_YES installs updates on SIGINT

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 05 Feb 2024 15:03:19 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276839

            Bug ID: 276839
           Summary: pkg upgrade with DEFAULT_ALWAYS_YES installs updates
                    on SIGINT
           Product: Base System
           Version: 14.0-RELEASE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: bin
          Assignee: bugs@FreeBSD.org
          Reporter: sthalik@tehran.lain.pl

When using pkg(8) with the 'upgrade' command, the program asks for confirmation
on stdin. The configuration option "DEFAULT_ALWAYS_YES" changes the [n/Y] port
into [Y/n] which is generally in line with other package management software
such as ones from Linux distributions.

However, pressing ^C on the 'pkg upgrade' [Y/n] confirmation prompt causes it
to actually perform the upgrade.

This violates POLA, and does so potentially causing downtime in case where
there was something wrong with the upgrade to perform. Please consider changing
SIGINT (and possibly SIGHUP in case where isatty(2) returns true) to act as if
'n' was chosen even for DEFAULT_ALWAYS_YES.

-- 
You are receiving this mail because:
You are the assignee for the bug.