[Bug 283698] New version of swab(3) breaks port graphics/dcraw

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283698

            Bug ID: 283698
           Summary: New version of swab(3) breaks port graphics/dcraw
           Product: Base System
           Version: 15.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: misc
          Assignee: bugs@FreeBSD.org
          Reporter: nwhitehorn@FreeBSD.org

The new version of swab(3) committed in
bac2eea13ae3e4dc8fd2aec261b2a18930138495 has slightly different semantics than
the old version. In particular, if the input and output buffers are identical,
the old version will work, but the new one -- which does not use a temporary
buffer like the old one did -- will not.

Strictly speaking, this is fine since the input and output pointers are marked
'restrict' so cannot be identical, but at least one program in the wild
(graphics/dcraw and all the versions of it in other photography programs) uses
identical buffers anyway and expects it to work.

Closing this "won't fix" is legitimate -- I will alert the dcraw developers as
well, since the bug is clearly on their end -- but I wanted to also write
something here since there appear to be compatibility implications both
relative to Linux and older versions of FreeBSD.

-- 
You are receiving this mail because:
You are the assignee for the bug.