[Bug 283583] makefs(8) -t zfs Assertion on unexpected devfs mount in directory

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283583

            Bug ID: 283583
           Summary: makefs(8) -t zfs Assertion on unexpected devfs mount
                    in directory
           Product: Base System
           Version: 14.2-RELEASE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: bin
          Assignee: bugs@FreeBSD.org
          Reporter: editor@callfortesting.org

While experimenting with PkgBase and makefs(8) -t zfs VM-IMAGES, I
inadvertently left a devfs mount in the directory that would become the rootfs
image using the soon-to-be-replaced release engineering VM-IMAGE tools in
/usr/src/release

Surprisingly, makefs(8) is devfs(8)-friendly:

'makefs -s 1g img.raw /dev'
Calculated size of `img.raw': 1073741824 bytes, 423 inodes
Extent size set to 32768
density reduced from 2538397 to 8192
img.raw: 1024.0MB (2097152 sectors) block size 32768, fragment size 4096
        using 2 cylinder groups of 626.00MB, 20032 blks, 80128 inodes.
super-block backups (for fsck -b #) at:
      64, 1282112
Populating `img.raw'
Image `img.raw' complete

However mounting devfs(8) on /tmp/test/devfs and making an image of the parent
directory /tmp/test results in:

'makefs -t zfs -s 1g -B little -o 'poolname=foo' img.raw /tmp/test/dev'
Assertion failed: (cur->type == S_IFREG || cur->type == S_IFDIR || cur->type ==
S_IFLNK), function fsnode_foreach, file
/home/pkgbuild/worktrees/releng/14.2/usr.sbin/makefs/zfs/fs.c, line 190.
Abort trap (core dumped)

The goal is not necessarily the ability to create a disk image containing
devfs(8), but rather to not core dump or provide the user a warning as
appropriate.

Tested on 14.2-RELEASE and I can provide the core file if this cannot be
reproduced.

-- 
You are receiving this mail because:
You are the assignee for the bug.