[Bug 278283] /usr/bin/calendar: 11 bugs fixed, major improvements [tarball]
- Reply: bugzilla-noreply_a_freebsd.org: "[Bug 278283] /usr/bin/calendar: 11 bugs fixed, major improvements [tarball]"
- Reply: bugzilla-noreply_a_freebsd.org: "[Bug 278283] /usr/bin/calendar: 11 bugs fixed, major improvements [tarball]"
- Reply: bugzilla-noreply_a_freebsd.org: "[Bug 278283] deskutils/calendar-data: 11 bugs fixed, major improvements [tarball]"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 09 Apr 2024 22:47:41 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278283 Bug ID: 278283 Summary: /usr/bin/calendar: 11 bugs fixed, major improvements [tarball] Product: Base System Version: Unspecified Hardware: Any OS: Any Status: New Keywords: feature, patch Severity: Affects Only Me Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: wbe@psr.com Flags: maintainer-feedback+ Created attachment 249868 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=249868&action=edit .tar.gz of *.h *.c Makefile CHANGES and added tests I've fixed 11 bugs, added several new features I think people will like, completely revised date parsing to add more flexibility and features, removed some never-used code, changed aliases, rewritten the man page to reflect all these changes and clarify how everything works now, and more. My changes are mostly backward compatible with the current version except for cases that I doubt exist or that probably shouldn't exist. E.g., current code allows aliases such as NewMoon=printf("foo"); and Easter=15. My new code requires aliases to be wholly alphabetic. This and similar new restrictions do not appear to be a problem for any of the files in deskutils/calendar-data 2022.11. The new code no longer fails in various cases in the calendar-data files where the current version fails. UTF-8 encoded national names now match case-independently, and various other things that didn't work before now do. * The attached tarball: As recommended by _Contributing to FreeBSD_, since the changes are large, I've attached a .tar.gz file with *.h, *.c, Makefile, and CHANGES. It includes the unchanged files pathnames.h, ostern.c, and paskha.c. Unchanged and not included in the tar file are: the rest of ./tests/* and ./calendar/calendar.freebsd. SHA256(the .tar.gz file) = e41259f330ea66d1036a5828684e41da4b673067b06fd81ccaf10bc53e26c7ae * Version number: The changes are big enough that I think they merit the next major version number. See CHANGES for more on this. * Copyright: I've added a Copyright 2024 FreeBSD.org notice to every file I changed that already had a Copyright notice. See CHANGES for why I think this is necessary and appropriate. * Maintainer offer: If you adopt my changes, then, for the time being, I'll offer to help maintain both calender and deskutils/calendar-data: you would forward new bug reports (or bugzilla bug numbers) to me, and I'd send fixes to you (or post the fix to bugzilla, or tell you it's something I can't fix). [Why do it that way? (1) I haven't really used git; and (2) I don't want to have to keep gigabytes worth of otherwise irrelevant src or ports git repository files around for less than 1MB worth of calendar files. Also, there'd be no need to issue me a commit bit.] Follow up to this bugzilla entry to let me know what you'd like to do. -WBE Maybe this'll make into 14.1? :) [I see bug #157748 from 2011 regarding files now in calendar-ports is still open. The changes look straight-forward enough, though some of the suggested changes may take a little research to confirm or may be outdated now. The links in that bug report that I tried still worked when I followed them a few weeks ago. I could look into that later.] -- You are receiving this mail because: You are the assignee for the bug.