[Bug 273289] smartpqi: fix panic on removal of SAS drive
- In reply to: bugzilla-noreply_a_freebsd.org: "[Bug 273289] panic on removal of SAS drive"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 19 Oct 2023 21:41:20 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273289
--- Comment #17 from commit-hook@FreeBSD.org ---
A commit in branch releng/14.0 references this bug:
URL:
https://cgit.FreeBSD.org/src/commit/?id=8fe059425a0919274e2c5b25a6af0568d147518d
commit 8fe059425a0919274e2c5b25a6af0568d147518d
Author: John F. Carr <jfc@mit.edu>
AuthorDate: 2023-10-19 03:25:31 +0000
Commit: Warner Losh <imp@FreeBSD.org>
CommitDate: 2023-10-19 21:37:29 +0000
smartpqi: Drop spinlock before freeing memory
pqisrc_free_device frees the device softc with the os spinlock
held. This causes crashes when devices are removed because the memory
free might sleep (which is prohibited with spin locks held). Drop the
spinlock before releasing the memory.
MFC After: 2 days
PR: 273289
Reviewed by: imp
(cherry picked from commit b064a4c9eed5b1dd2a40fc4fd2cb7e738b681547)
(cherry picked from commit 1ad148a68ae74f3372b12b6e66fadf5ade384144)
Approved-by: re (gjb)
sys/dev/smartpqi/smartpqi_discovery.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
You are receiving this mail because:
You are the assignee for the bug.