[Bug 271727] login.conf(5), setusercontext(): Gap when setting a realtime-class priority

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 16 Oct 2023 12:31:35 UTC

--- Comment #2 from commit-hook@FreeBSD.org ---
A commit in branch stable/14 references this bug:


commit af632cc56bc3781ef4409dffe9296d5a69bb281a
Author:     Olivier Certner <olce.freebsd@certner.fr>
AuthorDate: 2023-05-25 07:10:27 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2023-10-16 12:29:46 +0000

    setusercontext(): Fix gap when setting a realtime-class priority

    The login.conf's "priority" capability allows to set priorities in the
    idle or realtime classes in addition to the classical nice values (-20
    to 20), through a natural extension where values greater than 20 put the
    processes in the idle class (with priority adjusted within RTP_PRIO_MIN
    and RTP_PRIO_MAX, 21 being converted to 0, 22 to 1, etc.) and values
    lower than -20 put the process in the realtime class (with priority
    adjusted within RTP_PRIO_MIN and RTP_PRIO_MAX, -21 being converted to
    RTP_PRIO_MAX (31), -22 to 30, etc.).

    Before this fix, in the latter case (realtime class), -21 was converted
    to 30, and RTP_PRIO_MAX (31) could never be specified.

    While here, change the priority computation for the idle-class case to
    be symmetrical and use RTP_PRIO_MIN (in practice, this changes nothing
    at all, since RTP_PRIO_MIN is 0; but this is the correct theoretical
    formula, which would work as well with other values of RTP_PRIO_MIN).

    PR:                     271727
    Reviewed by:            imp, kib
    MFC after:              2 weeks
    Sponsored by:           Kumacom SAS
    Differential Revision:  https://reviews.freebsd.org/D40339

    (cherry picked from commit bd572be78436473a2ad4c1b78728b739c74ef238)

 lib/libutil/login_class.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

You are receiving this mail because:
You are the assignee for the bug.