From nobody Sun Nov 26 10:14:29 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SdPhj23X6z52Y6p for ; Sun, 26 Nov 2023 10:14:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SdPhj004Qz4F1m for ; Sun, 26 Nov 2023 10:14:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1700993669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nWvVksWajUbAZBbndy10PunQ7si3irvlPYjoWDUdSwI=; b=bL6eX82jI+sIvnf7kVf+SpqftOKrLJuKMwIaFmKc2tk3fsvlU0V8enpJivPczwcpai632m lgifBQ4zsBZzQfEuQpXNBGZDBIJXggsGVpg0NCAbvEd3KrCvpuwazGrk3Qv78NPXGuajDN 9t6tvS3XobERm3q4vE61I4rQP7gFOad5L64WJrmhv0Y5Ytde1xHb73YqeQhs4qpXRhy2ui t57hvjkNin+sBM+nujpukPmGyS9qSfuWccGbEBuFK6JUiYnECsyKi8GxEUC/OkDjVaV83Z 8mi9TYt/kSCoQq2KP7H/rvp9JPv1I9guYGVizIjac1GLvvANDd/bTr5z9wxAeA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1700993669; a=rsa-sha256; cv=none; b=uZhkA3YJJLuZNRMewbDLErxS85DcBfIg//TuodLywGuffMp3kyuk1RcVgCmg2fpgkCrDkg HK9H+F8B3fsFiiv9WZ9F3LuJn4UQRox5Xa2vhLnYcWhHVyF9aLAbfr32W65dc8S9EwOMtE pwfByboNeGICFDIBepw3i5RwhB6DMf5AYxc3/jM3qSXfE80JdwTGLNty9gekYCntt3FS/a IgM6rcCvDYLVBt88RXDQqQQBnVGKS0M8IpJwsUE7wN8pcu8db/v9HYVckfjqQ/bj3Pjkzr +WicxBYxD/VJRfLhtvkktTIS7tzCBKPo93//goA3EdrtuS1FTzBudbOKANtwtw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SdPhh691hzr1Z for ; Sun, 26 Nov 2023 10:14:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3AQAESEX036652 for ; Sun, 26 Nov 2023 10:14:28 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3AQAES2N036651 for bugs@FreeBSD.org; Sun, 26 Nov 2023 10:14:28 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 273088] /etc/periodic/weekly/340.noid: extend to support /etc/jail.conf.d/ exclusions Date: Sun, 26 Nov 2023 10:14:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: markus@stoffdv.at X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273088 --- Comment #2 from Markus Stoff --- I don't know why this request has not received any feedback, but I also thi= nk that this script should consider the same sources as /etc/rc.d/jail. Everyt= hing else is counterintuitive and should probably be considered unexpected behav= ior. Therefore I've added a second attachment which also fixes another issue with the original script. The "-e" option separates the parameters by the separator provided. However, each jails parameters will be on a separate line (i.e. a new line character= is inserted after the last parameter of a jail). In case the "path" parameter is the last parameter of a jail, the script wi= ll consider the line break and the first parameter of the next jail as part of= the value. Example: $ cat /etc/jail.conf issue { path =3D '/some/path'; } cause { path =3D '/another/path'; } $ jail -f /etc/jail.conf -e : name=3Dissue:path=3D/some/path name=3Dcause:path=3D/another/path In the above case, the script would try to hand "-path /some/path$'\n'name=3Dcause -prune" to find, leading it to fail to parse its arguments (resulting in a noop for this script). Therefore I changed the separator to the newline character. Another option = to fix the bug would be to just add the newline character to IFS. However, usi= ng newline as a separator allowed to simplify and optimize the main loop. --=20 You are receiving this mail because: You are the assignee for the bug.=