[Bug 112379] [patch] [request] lockf(1): on closing stdin, stdout, stderr

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=112379

--- Comment #4 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=18425c19cae08cbe41801845457ed67285806688

commit 18425c19cae08cbe41801845457ed67285806688
Author:     Alexander Melkov <melkov@comptek.ru>
AuthorDate: 2023-11-22 04:46:28 +0000
Commit:     Kyle Evans <kevans@FreeBSD.org>
CommitDate: 2023-11-26 04:09:27 +0000

    lockf: don't hold stdin/stdout/stderr open

    None of these are essential in the lockf monitor (parent post-fork), so
    close them to maintain the illusion that lockf hasn't been inserted into
    the pipeline.  This ensures that the correct effects happen on other
    programs in the pipeline if the locked command closes or redirects these
    elsewhere.

    The original patch used -s to close stdout/stderr rather than closing
    them unconditionally, but it's not clear that we really care that much.
    kevans dropped that part when taking the patch, patch is otherwise by
    listed author.

    PR:             112379
    Reviewed by:    0mp, allanjude (both earlier version), kevans
    Feedback from:  des
    Sponsored by:   Klara, Inc.
    Differential Revision:  https://reviews.freebsd.org/D42713

 usr.bin/lockf/lockf.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.