From nobody Thu May 11 11:57:59 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QH9Pz4HWbz4B85N for ; Thu, 11 May 2023 11:57:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QH9Pz1TXTz43Kc for ; Thu, 11 May 2023 11:57:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683806279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QSwHa5ZUJZvz65uJjUBVWicbOPAfAPzXDIDsEEO+nSQ=; b=mH5FQ7AE958mWbGQkWOBAfm9RXfP1tfWYCBEAvjoxxIzu1+/JO03VSAOM2/H3lBwDqv6KA Z6X3Ni1AFIVNR7v0gIYa8qHI4jv+hXeQT/7T11UZAuAoq3YznoS9P9qah4G0IwqisvCXWd XUq+AnprbUm3SmYYuVYT8DSSk0N6iV3bSQsC8bFCACAcH+BZxzs8n86kPn5epnMlwqm1eq QHiTVEF+SO3bYxJx6yVqx+y30R5SZxle4/eoTav9476ECbzsWTEZAtLT1z/gsc9UxkJ3Zl IjWXBgKg7qeIhBr8z/JxAQcA6XHTsZm1KZKbStQHzRK3kvuHLKV7S/lZ09cGgQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683806279; a=rsa-sha256; cv=none; b=iXrUoSfNrv/Aq234h2XsOUgEgQKtVOizFeFr00d2iY7UfyY5jPTvnPMqdcmpjYD1KKPkzc lkuceg+4vEv3gXdrX7gRT84pqCoOpqlu4Iz3LBkQMcdrkGn85t/0C/u13nJhshct63902+ VoxBqPExjQ1nU2XXFgx6k3XsCncFhAbkAfEJmmVHlhIAbETT2/0V17ZG25cPxLJdIEMtsa nw2/SF4ZND/t30AZkBLuAyslXYBFj5ylGb5ARUszuxRa5ou13Z34E294/u1TKMSHaxjU8l lQ0qpO0VKGaayvIGDxqj+L2qqqbVvFR/1lEUj8idllBmGVByJTz3dI/nkayozA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QH9Pz0LJWzrPX for ; Thu, 11 May 2023 11:57:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 34BBvweb081220 for ; Thu, 11 May 2023 11:57:58 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 34BBvwWX081219 for bugs@FreeBSD.org; Thu, 11 May 2023 11:57:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 142434] [patch] Add cpuset(1) support to rc.subr(8) Date: Thu, 11 May 2023 11:57:59 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 7.2-RELEASE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: 000.fbsd@quip.cz X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: kevans@freebsd.org X-Bugzilla-Flags: mfc-stable13? mfc-stable12- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D142434 --- Comment #14 from Miroslav Lachman <000.fbsd@quip.cz> --- 13 years after my initial patch submission :) Thank you for taking care of = it! I noticed you committed with my debugging code + comment. # for cpuset debug only, not committable (cut) if [ -n "$_cpuset" -a -x $CPUSET ]; then echo -n "on CPU(s)" $CPUSET -g -p "$rc_pid" | cut -s -d: -f 2 fi I think this information is really useful for "status" and should be there,= but I was not sure if it is OK to use pipe and cut (utilities from /usr/bin). M= aybe it is OK because now I see "kldstat -v | egrep -q -e" elsewhere in rc.subr.= =20 (I think egrep is not recommended and should be grep -E for compatibility) Back to topic - if it is good to have this code in rc.subr, please remove t= he comment line:=20 "# for cpuset debug only, not committable (cut)" And I would like to ask if anyone has tested it with the current rc.d/jail?= I remember it did not work with jail 13 years ago, but a lot has changed in t= hat time. I don't know if it will work or if it will just silently not set cpus= et without breaking anything or jail will not start at all. Just to be on the = safe side. --=20 You are receiving this mail because: You are on the CC list for the bug.=