From nobody Sat May 06 06:05:12 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QCxqD2zd9z496Dj for ; Sat, 6 May 2023 06:05:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QCxqC6tSmz3H3K for ; Sat, 6 May 2023 06:05:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683353112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H4bOqEQR17tLNnw35DRpFMdWIo8ie67e9jBZ2S1BcNA=; b=m1TGhGrCPbTrZwwfHCdUGahVUfjJmSMBR3rP0HHQ8BKGfrx5g6EXyVaK6PPdH/iMV7BsnD ddPQtaE0dMxRVKhJJ0ct/v3aOFefk37ne0MUK8CWqI/qR1pCwJCozzMAKzHp0KATrlWWar zto3NhwYrSZOwfC10MhRxfDlfciNcN/2eWsOwwjqnzSAmG3jux/mYRnT9EZ9ydUac6u5Mb zr0kakXUOM8qN0+d9fWRPBUWfKxGeoo94QdC73/EgZwBl4Nv6nnvdn8uXjxvNeZAZ9KaXz i6ijb1bPGtHAZs8ZCYB3LWXD0WDC5dtRKReDxJm87ICzVRnZ15dAag+5ErXuLA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683353112; a=rsa-sha256; cv=none; b=f4v694oQTOXgQbIcJRz5uSfOc71gpPYgdnkqihMM8y2uJrdbTmTPIQRve6GZvqWZD/bIKm xOmbX/YefIj2vl9Djuuawf/eCz9OhVVKfX9/ftZWhC32aR4MFXsDKHtNz8iiuD+RTs8pP8 NbqHk4JA5Bp5GkGi6STDai1uvwx7QWL5V7BuhnRS/yB3uYVzis6m1z6taAFX1GsBZWaWXM 4VB18iMy2/O+Kq7/wC8G04AwtbZhuLLvEVM/JLSDit++zmQwq98292vJfNJVRwPSdqfaQd kowalRZHIMb3aruFq129qhC1SqQEjLX/dPwqob/j0ncVbSSoC5m/FDBgw8Gx9A== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QCxqC5ztwzQJd for ; Sat, 6 May 2023 06:05:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 34665BXa052034 for ; Sat, 6 May 2023 06:05:11 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 34665BSi052033 for bugs@FreeBSD.org; Sat, 6 May 2023 06:05:11 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 271262] bsdinstaller in AutoZFS + MBR mode always wipes disklabel - rendering system non-bootable Date: Sat, 06 May 2023 06:05:12 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: hpaluch@seznam.cz X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271262 --- Comment #2 from Henryk Paluch --- Additional details: The original installation disklabel looks that way: (the da0s1a was create by install using: gpart add -i 1 -t freebsd-zfs -s 2147483648b "da0s1") # /dev/da0s1: 8 partitions: # size offset fstype [fsize bsize bps/cpg] a: 4194304 0 ZFS=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20 b: 4194304 4194304 swap=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20 c: 18874304 0 unused 0 0 # "raw" part, don't edit d: 4194304 8388608 ZFS=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20 Please notice that da0s1 starts at 0 - so extreme care must be taken to not overwrite disklabel on 2nd sector (byte offest from 512 to 1023). =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Using development machine with 2nd disk and GDB I have found following stacktrace (by putting breakpoint just at __sys_write): reakpoint 1.2, _write () at _write.S:4 4 _write.S: No such file or directory. (gdb) bt #0 _write () at _write.S:4 #1 0x00000008011af1f6 in __thr_write (fd=3D6, buf=3D0x7fffffffb040, nbytes= =3D4096) at /usr/src/lib/libthr/thread/thr_syscalls.c:618 #2 0x000000000104c900 in zero_label (path=3Dpath@entry=3D0x7fffffffc190 "/dev/da1s1a") at /usr/src/sys/contrib/openzfs/cmd/zpool/zpool_vdev.c:905 #3 0x000000000104b5f0 in make_disks (zhp=3Dzhp@entry=3D0x0, nv=3D0x801c104= 20) at /usr/src/sys/contrib/openzfs/cmd/zpool/zpool_vdev.c:1048 #4 0x000000000104b333 in make_disks (zhp=3Dzhp@entry=3D0x0, nv=3Dnv@entry=3D0x801c1d080) at /usr/src/sys/contrib/openzfs/cmd/zpool/zpool_vdev.c:1070 #5 0x000000000104b8e1 in make_root_vdev (zhp=3D0x6, zhp@entry=3D0x0, props=3D, force=3Dforce@entry=3D1,=20 check_rep=3D, replacing=3Dreplacing@entry=3DB_FALSE, dryrun=3Ddryrun@entry=3DB_FALSE, argc=3D1,=20 argv=3D0x801c36040) at /usr/src/sys/contrib/openzfs/cmd/zpool/zpool_vdev.c:1864 #6 0x0000000001036ef9 in zpool_do_create (argc=3D, argv=3D) at /usr/src/sys/contrib/openzfs/cmd/zpool/zpool_main.c:1587 #7 0x00000000010364b6 in main (argc=3D9, argv=3D0x7fffffffeb38) at /usr/src/sys/contrib/openzfs/cmd/zpool/zpool_main.c:10755 The problematic code is on=20 #3 0x000000000104b5f0 in make_disks (zhp=3Dzhp@entry=3D0x0, nv=3D0x801c104= 20) at /usr/src/sys/contrib/openzfs/cmd/zpool/zpool_vdev.c:1048 Which looks like: ret =3D zero_label(udevpath); if (ret) return (ret); Here is source pointer but the line offset is a bit different from what I s= ee in local sources of 13.2. release: - https://cgit.freebsd.org/src/blame/sys/contrib/openzfs/cmd/zpool/zpool_vdev= .c?h=3Dreleng/13.2#n1080 And this is problem - overwriting disklabel.. --=20 You are receiving this mail because: You are the assignee for the bug.=