From nobody Fri Mar 17 20:05:48 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PdZrD0Wfqz3ymqh for ; Fri, 17 Mar 2023 20:05:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PdZrC6MmPz3Qbq for ; Fri, 17 Mar 2023 20:05:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679083547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LpmlFYlSS3LB/sGs64A14nnM95/WXh/lIU0I4TzkDhk=; b=YttnOPgvLcO22DxIayKork+sO1Yd72Tr68PVPA8VRr9pmpO+Bu0zz8Eq1DboNEI97+MzE8 G/hdURQmT6/VuNHSG8ovhqRIztHLpZHa8jm73X+2IKkjadLAWOkZelYDGK7fG/qdrkMt7+ 5da0YpLwCRigJR6NzO6Lns9FIfyq+x1rYmyfB5TqqyUZPkoQdJLspGUKxli+LXF/8gn45U MFqsvswl/UWYKszrFozT35MkXe0O21C+G15ZfGn5d1dEzoSMBE0BTMD12RhYbUpppaZvAr NsrLAXvzKu1WN8l5GsRZeKk+ZF+Ur2giqdoknoyeyU5Hrno704Xm3waTAZ94+w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679083547; a=rsa-sha256; cv=none; b=ak8sbDClE9ab2DwE2R/KCCDP6lsFvhV7DRqOYQyXbdXGIuRhObAyvUazURlNRa5e0JHg+p 0cJS+nYPesQCcBMEqvVRJVnJR5ykxf1ym+5oFK5rvn3AAlL+K3k27cEaO34whiRR7SuH8t TBrnz1Z+DpeuLv0UXwMkpm5DXGkWt04SVyqNDaTuOgZ3US3dDqzq0KcXMrQHQlio1GXUGf Kil/eAHX4ONvVIDPhugvpCVb5b6aKx+K4fOrN41JopfMKJKvNALGutxLPrqpJ4gjgI7LMR +ogXXOm9NeSc5GBTy7l2QgGZR4PJp8jBR/zhJZxifdb1Pann3WcdN0xRGVVRYQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PdZrC5ThKzfTv for ; Fri, 17 Mar 2023 20:05:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 32HK5lRj073191 for ; Fri, 17 Mar 2023 20:05:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 32HK5l0r073190 for bugs@FreeBSD.org; Fri, 17 Mar 2023 20:05:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 270270] mii: memory leak when mii_attach() fails Date: Fri, 17 Mar 2023 20:05:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: jiahali@blackberry.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270270 --- Comment #3 from Jiahao LI --- (In reply to Mina Gali=C4=87 from comment #2) Thanks for the suggestions. I agree that it would be better to clean up the softc in device_delete_chil= d(). Since changing the device_delete_child() would have an impact on many devic= es and the softc will be allocated if the "miibus" input parameter of mii_atta= ch() is null, I only change it in the mii_attach() for minimal impact of other components. It would be better that Freebsd can re-investigate the memory allocation issues using device_*() APIs. --=20 You are receiving this mail because: You are the assignee for the bug.=