From nobody Fri Jun 16 19:07:18 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QjTDl0L6Mz4fWbq for ; Fri, 16 Jun 2023 19:07:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QjTDk6Nr0z3wVk for ; Fri, 16 Jun 2023 19:07:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686942438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ui0MG6Nm5DBIolhcxGSeUAyVJjXyOKQxUJrdg8PX954=; b=UxIh41qd4yo1kXX4cd+QI2YCNiJVTeEEWd/7ydOo4qswqyX57GE5IKyUMtr4Hfh+ULbzwj LmRAqZSadM/eOeRPK/yo0rIsEEmZt2x5h0a91s5fo6gjaMYjY5/Ws5z3fOCRxxirxFuPUv a582lV3/ZkkHv7s1neiVw2FHnSsYfyo/8M4Fdcr7LThmA3FSLpFzbkrRcoCuQQ94ggw1CV A4owBfAl7efY9w7no0otYgD7WTPIZuPw/3TJDabuUZIsPdL+tQzobj7LPQ7cskluFUaQwZ grGhO8Qb0WMMU5nF70Lx71W8+HXAyqGrl1LNOUZcs+/1Ng+2mWvLchN0dYH1uA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1686942438; a=rsa-sha256; cv=none; b=kkkhImcDBDd3yedXIUwHhgQspC124F9Uh9fxyqTMc3/UXoN5td+EfnwWwQ7zAB8f9V+4O1 Kg3PSS4zpA2rN1596hxI5lxtJtW+Z+iR+bcSJG+eOPfN60oUAU5xb65q+ih7Zv9TplPiZw JrLeVEvUEMBref95deQ3aM9RsrL8heWwUIXTtaOVQdwIRVP8qVCTvDkYp1Ui1Pn5+76Eqx 0YCbMLBp83bSnu6chrnTM4oiRZzczT8V2dh/2/rmNeVetgq+4sILggDhQx3ycm+9NAuccB yQBdzpYpQtQd1/TuSDxed2UO1PknkPgo63vlcxLP7FChB3aOpYETd/hOeFRWxA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QjTDk5Tdnzfcp for ; Fri, 16 Jun 2023 19:07:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 35GJ7IVY011577 for ; Fri, 16 Jun 2023 19:07:18 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 35GJ7InG011576 for bugs@FreeBSD.org; Fri, 16 Jun 2023 19:07:18 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 271991] Crash on some network packets with fresh stable Date: Fri, 16 Jun 2023 19:07:18 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271991 --- Comment #6 from Mark Johnston --- So to fix the immediate problem (i.e., the crash): - ng_bpf should stop copying/pulling up unless "usejit" is set. bpf_filter= () can handle mbuf chains, it doesn't require a contiguous buffer. Note that bpf_mtap() and bpf_mtap2() do not do any pullups or copying. Then: - Make bpf handle unmapped mbufs. Note that with unmapped mbufs, protocol headers will still be mapped, so to trigger any problem you need a BPF prog= ram which reaches into the TCP payload. Bonus points: - Teach virtio-net (and probably other paravirtualized NIC drivers, like ena and gve?) to handle unmapped mbufs. --=20 You are receiving this mail because: You are the assignee for the bug.=