From nobody Sat Jan 28 13:38:05 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P3wW145rKz3cJyy for ; Sat, 28 Jan 2023 13:38:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P3wW12mM6z3m85 for ; Sat, 28 Jan 2023 13:38:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674913085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JysDISXTlsJG/pXOQ/EJnBHrBIIpVpHOvCqX3j7/fFU=; b=wzEUlIas17fOzVo8Se5pqNQk0WRzMPRhIPoV97LKSXJ0Hz7P/M2tJW9ZPrn5S9q51hJuAv /3ONqpgMUqzIDYptWPOaEhhFkdRYV3zNHrJH7lij8PtTzcHoq8nWZHdgy2PkkCj2nsK23b aCy7UmvQ9hCkr0f/HmBuh/5kH1RCEsSS19aqGrDmRiHvTlrpRkKFN7cnFx+DvHKxdG2HCA pp5qUeqcp+DZ6l746tKdP70OZO8y5zy3EfVbREY6+6tjgOl0RocqeHqLFQhDwdzAmYLOmG IpI8xMBK9GN1KAqMGxiVPet5vhE9xqa5LeSTLgfaR7Rp46D1isRaDCjRbb7hHQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674913085; a=rsa-sha256; cv=none; b=g/17CLli/wF6af3Aal/tvsDDAZ03Nxp2rie0Ydgpcu0ZaHp2amXAdVAgeCIEFGarJmYHpl 69LVpQoiom4Fj3fNpJLWIP48HdHqkIAvN3FlzgW08dW63jnURg2XW+rVSLZ4m9XuPBWWf5 xJQTrH1WlwEezxOgZjDDI14gVFbOxAVGhViTRmsqc7SIUwwyRsMtWTe614scyJrvCOmp3d nDSJv2BYr9wSnl07xFi1HBG6ojz8s4BCmVLSUgYBMiOL21loGKWD6qFT9m8uBnhx+tVUTV ch3qF8hXfOzLUgvb02F78kNx9ocQAfTQIuzvxdHllv9C49Uck/tU5gC7ab+3Mw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P3wW11gRxzrSw for ; Sat, 28 Jan 2023 13:38:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 30SDc5pr070118 for ; Sat, 28 Jan 2023 13:38:05 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 30SDc57V070117 for bugs@FreeBSD.org; Sat, 28 Jan 2023 13:38:05 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 269190] bugs in stat(1) and devname(3), wrong report on disk names Date: Sat, 28 Jan 2023 13:38:05 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269190 Konstantin Belousov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kib@FreeBSD.org --- Comment #1 from Konstantin Belousov --- WRT the stat(1) patch, why do you _not_ pass S_IFBLK when the device is the block device? IMO it is more correct to do the following: #if HAVE_DEVNAME - sdata =3D (what =3D=3D SHOW_st_dev) ? - devname(st->st_dev, S_IFBLK) : - devname(st->st_rdev,=20 - S_ISCHR(st->st_mode) ? S_IFCHR : - S_ISBLK(st->st_mode) ? S_IFBLK : - 0U); - if (sdata =3D=3D NULL) - sdata =3D "???"; + sdata =3D devname(what =3D=3D SHOW_st_dev ? st->st_dev : + st->st_rdev, S_ISCHR(st->st_mode) ? S_IFCHR : + (S_ISBLK(st->st_mode) ? S_IFBLK : 0)); #endif /* HAVE_DEVNAME */ --=20 You are receiving this mail because: You are the assignee for the bug.=